Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search improvements #4320

Merged
merged 4 commits into from
Sep 16, 2016
Merged

Search improvements #4320

merged 4 commits into from
Sep 16, 2016

Conversation

lucasvanhalst
Copy link
Contributor

@RocketChat/core

Closes #3549

Improves the search so you can filter on more things.

  • You can now enter from:me to search for messages only created by the current user.
  • has:star returns messages that are starred by the current user
  • is:pinned or has:pin returns messages that are pinned in the current channel
  • has:url or has:link returns messages that contain a link
  • has:location or has:map returns messages that have a location attached
  • before:dd/MM/YYYY, after:dd/MM/YYYY and on:dd/MM/YYYY return message that were created before, after or on the provided date respectively. You can also use dashes - or dots . instead of slashes.
  • order:asc sorts messages by ascending timestamp. You can also use order:ascend or order:ascending
  • order:desc sorts messages by ascending timestamp. You can also use order:descend or order:descending.

There is no indication in the UI that is this possible though.

I've also converted the coffeescript to js since I know you guys are doing this step by step.

Add possibility to search on:
- from:me
- has:star
- has:url|has:link
- is:pinned|has:pin
- has:location|has:map
- before:dd-MM-yyyy
- after:dd-MM-yyyy
- on:dd-MM-yyyy
- order|sort:asc|ascend|ascending|desc|descend|descending
@geekgonecrazy
Copy link
Contributor

@lucasvanhalst this is really cool! So with all of this we kind of need a cheatsheet quick help thing there in the search.

@sampaiodiego
Copy link
Member

that is indeed really cool!

@lucasvanhalst
Copy link
Contributor Author

lucasvanhalst commented Sep 16, 2016

Yeah something like this @geekgonecrazy

@geekgonecrazy
Copy link
Contributor

@lucasvanhalst ah yes! Agreed, that looks nice

@engelgabriel engelgabriel merged commit 88c8b6d into RocketChat:develop Sep 16, 2016
@lucasvanhalst lucasvanhalst deleted the search_improvements branch September 17, 2016 12:40
@alfredbez
Copy link

There is no indication in the UI that is this possible though.

I'd like to see 2 things here:

  1. add instructions, maybe here
  2. highlight filters ins searchbox (like in slack)

image

Date-filter seems buggy:
image

I create two new seperate issues

@geekgonecrazy
Copy link
Contributor

@alfredbez we'd welcome another PR to add that. 😄

@lucasvanhalst
Copy link
Contributor Author

It's true that the date filters don't won't properly. They did on my test environment of course.. God I hate time zones :D

@graywolf336
Copy link
Contributor

graywolf336 commented Feb 13, 2017

To follow up, the dates still work but it's not in the American format. It is dayday/monthmonth/year, so for Feburary 11th, 2017 the search would be: on:11/02/2017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] time range search, search by time
7 participants