Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow simpler pinning/unpinning via the methods, only require _id & rid #5087

Merged
merged 1 commit into from Dec 1, 2016

Conversation

@graywolf336
Copy link
Member

commented Dec 1, 2016

@RocketChat/core

This allows for much simpler pinning via the meteor methods, which is helpful for any additional clients so they only have to pass the _id and rid instead of the full message.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-5087 Dec 1, 2016 Inactive

@graywolf336

This comment has been minimized.

Copy link
Member Author

commented Dec 1, 2016

@rodrigok or @sampaiodiego mind taking a look?

@engelgabriel engelgabriel merged commit 3b25088 into develop Dec 1, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@engelgabriel engelgabriel deleted the minimize-pinning-requirements branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.