Fix search not coming up #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #531
|
Maybe you can accept ctrlKey and metaKey? |
|
I prefer Meta + P (Command + P) because this is the shortcut of sublime and chorme dev tools to navigate in files in Mac. |
|
Switched from just ctrl to ctrl or meta. |
|
Thanks |
This was referenced Dec 24, 2020
Shailesh351
pushed a commit
to Shailesh351/Rocket.Chat
that referenced
this pull request
Mar 11, 2021
…551a16 [Upstream Catchup] Merge RC:master to develop_pwa
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #531
Tested this on mac / windows / linux. Super + p on windows and linux is a no go.
On the gnome display environment in linux it actually is bound to changing between mirrored and extended for your monitors.