New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Duplicate code in rest api letting in a few bugs with the rest api #8408

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
3 participants
@graywolf336
Member

graywolf336 commented Oct 5, 2017

@RocketChat/core moves a few internal things around with how the parseJsonQuery helper handles things, this way each individual controller doesn't have to worry about the result of that helper.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8408 Oct 5, 2017 Inactive

@rodrigok rodrigok added this to the 0.59.0-rc.12 milestone Oct 5, 2017

@rodrigok rodrigok merged commit 10f8985 into develop Oct 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@rodrigok rodrigok deleted the rest-api-improve-json-query-helper branch Oct 5, 2017

rodrigok added a commit that referenced this pull request Oct 6, 2017

Merge pull request #8408 from RocketChat/rest-api-improve-json-query-…
…helper

[FIX] Duplicate code in rest api letting in a few bugs with the rest api
# Conflicts:
#	packages/rocketchat-api/server/api.js
#	packages/rocketchat-api/server/v1/channels.js
#	packages/rocketchat-api/server/v1/groups.js
#	packages/rocketchat-api/server/v1/im.js

rodrigok added a commit that referenced this pull request Oct 6, 2017

Merge pull request #8408 from RocketChat/rest-api-improve-json-query-…
…helper

[FIX] Duplicate code in rest api letting in a few bugs with the rest api
# Conflicts:
#	packages/rocketchat-api/server/api.js
#	packages/rocketchat-api/server/v1/channels.js
#	packages/rocketchat-api/server/v1/groups.js
#	packages/rocketchat-api/server/v1/im.js

rodrigok added a commit that referenced this pull request Oct 9, 2017

Merge pull request #8408 from RocketChat/rest-api-improve-json-query-…
…helper

[FIX] Duplicate code in rest api letting in a few bugs with the rest api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment