Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] New REST API to mark channel as read #9507

Merged
merged 6 commits into from Feb 8, 2018

Conversation

Projects
4 participants
@rafaelks
Copy link
Collaborator

commented Jan 25, 2018

@RocketChat/core

This PR introduces a new REST API, that allows user to mark any room as read.

Progress

  • API REST
  • Tests (need improvements)
  • Docs

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9507 Jan 25, 2018 Inactive

@rafaelks

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 25, 2018

Documentation PR created: RocketChat/docs#525.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9507 Jan 25, 2018 Inactive

rafaelks added some commits Jan 25, 2018

Merge branch 'feature/mark_as_read_rest_api' of github.com:RocketChat…
…/Rocket.Chat into feature/mark_as_read_rest_api

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9507 Jan 25, 2018 Inactive

@rafaelks rafaelks changed the title [WIP][NEW] Add a new API that allows to mark any channel as read [NEW] Add a new API that allows to mark any channel as read Jan 25, 2018

@rafaelks

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 25, 2018

I feel like the tests needs to be improved, checkin with real objects of type channel, group and DM. Can someone help me doing that? Couldn't find any example of that.

@RocketChat RocketChat deleted a comment from codacy-bot Jan 25, 2018

@RocketChat RocketChat deleted a comment from codacy-bot Jan 25, 2018

@RocketChat RocketChat deleted a comment from codacy-bot Jan 25, 2018

@RocketChat RocketChat deleted a comment from codacy-bot Jan 25, 2018

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9507 Jan 25, 2018 Inactive

@rafaelks rafaelks changed the title [NEW] Add a new API that allows to mark any channel as read [NEW] Add a new REST API that allows to mark any channel as read Jan 25, 2018

@rodrigok rodrigok added this to the 0.62.0 milestone Jan 26, 2018

@rodrigok rodrigok added this to Backlog in 0.62.0 Jan 30, 2018

@rodrigok rodrigok requested review from rodrigok and MarcosSpessatto Jan 30, 2018

@MarcosSpessatto
Copy link
Member

left a comment

Nice work.

@rodrigok rodrigok changed the title [NEW] Add a new REST API that allows to mark any channel as read [NEW] New REST API to mark channel as read Feb 8, 2018

@rodrigok rodrigok merged commit 38c16a9 into develop Feb 8, 2018

4 of 5 checks passed

continuous-integration/drone/push this build is pending
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog Your tests passed on CircleCI!
Details
ci/circleci: test-without-oplog Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rodrigok rodrigok deleted the feature/mark_as_read_rest_api branch Feb 8, 2018

@theorenck theorenck moved this from Backlog to Done in 0.62.0 Feb 14, 2018

@rodrigok rodrigok referenced this pull request Feb 28, 2018

Merged

Release 0.62.0 #9935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.