Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Version update check #9793

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
5 participants
@rodrigok
Copy link
Member

commented Feb 20, 2018

@RocketChat/core

screen shot 2018-02-20 at 11 54 33 pm

Closes #9542

  • Show banner to admins
  • Send message via Rocket.Cat to admins
  • Send email to admins
  • Allow dismiss the banner
  • Do not alert multiple times
  • Alert security updates

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9793 Feb 20, 2018 Inactive

@rodrigok rodrigok added this to the 0.62.0 milestone Feb 20, 2018

@rodrigok rodrigok added this to Desirable in 0.62.0 via automation Feb 20, 2018

@gdelavald

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2018

Can we display the 'update your instance' only for admins? Seems more reasonable than showing to every user on the server.

@geekgonecrazy

This comment has been minimized.

Copy link
Member

commented Feb 20, 2018

Agreed! Maybe a role filter on the alerts so can restrict to just admin?

Also will this show every time they restart an instance(single instance or multiple instance situations)

@sampaiodiego

This comment has been minimized.

Copy link
Member

commented Feb 20, 2018

it IS already filtering only admins

@geekgonecrazy

This comment has been minimized.

Copy link
Member

commented Feb 20, 2018

oh duh! 😊

I might be missing cause I did the last part :) but looks like once you dismiss it deletes the banner. What's to keep it from showing up again? Or if I restart an instance it showing up again?

@rodrigok rodrigok moved this from Desirable to To Do in 0.62.0 Feb 20, 2018

@rodrigok rodrigok moved this from To Do to In progress in 0.62.0 Feb 21, 2018

@rodrigok rodrigok moved this from In progress to Review/QA in 0.62.0 Feb 21, 2018

@rodrigok rodrigok force-pushed the version-update-check branch Feb 21, 2018

@rodrigok rodrigok requested a deployment to rocket-chat-pr-9793 Feb 21, 2018 Abandoned

@rodrigok rodrigok force-pushed the version-update-check branch Feb 21, 2018

@rodrigok rodrigok requested a deployment to rocket-chat-pr-9793 Feb 21, 2018 Abandoned

@rodrigok

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2018

@geekgonecrazy if you click to see more information the banner will not close, but if you close it will be removed from database and will not be showed again until we release a new version.

@rodrigok rodrigok closed this Feb 21, 2018

@rodrigok rodrigok reopened this Feb 21, 2018

0.62.0 automation moved this from Review/QA to In progress Feb 21, 2018

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9793 Feb 21, 2018 Inactive

@rodrigok rodrigok force-pushed the version-update-check branch Feb 21, 2018

@rodrigok rodrigok force-pushed the version-update-check branch to b81b366 Feb 21, 2018

@rodrigok rodrigok requested a deployment to rocket-chat-pr-9793 Feb 21, 2018 Abandoned

@rodrigok rodrigok moved this from In progress to Review/QA in 0.62.0 Feb 21, 2018

@rodrigok rodrigok merged commit 57db263 into develop Feb 21, 2018

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog Your tests passed on CircleCI!
Details
ci/circleci: test-without-oplog Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

0.62.0 automation moved this from Review/QA to Done Feb 21, 2018

@rodrigok rodrigok deleted the version-update-check branch Feb 21, 2018

@rodrigok rodrigok referenced this pull request Feb 28, 2018

Merged

Release 0.62.0 #9935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.