Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead code removal #74

Merged
merged 14 commits into from Oct 8, 2019

Conversation

@RocketMan
Copy link
Owner

commented Oct 4, 2019

There is a fair amount of dead code, which has persisted for historical reference, but is no longer relevant. This PR removes the dead code and optimizes inefficient constructs.

Acceptance testing notes: There should be no change in functionality relative to master.

@RocketMan

This comment has been minimized.

Copy link
Owner Author

commented Oct 4, 2019

Important note: Much legacy code consisted of one of a pair of methods whose names differed only by the suffix '2'. Commit 1fd62d3 renames the remaining method and its invocations/references, such that the '2'-suffixed methods are no more. As a result, some methods have effectively changed name. For example, the legacy method 'getCurrents' was deprecated; the remaining method 'getCurrents2' was refactored to 'getCurrents'.

@RocketMan RocketMan merged commit 78d8640 into master Oct 8, 2019
@RocketMan RocketMan deleted the dead-code-removal branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.