New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work properly with current minetest-dev #19

Open
VanessaE opened this Issue Feb 17, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@VanessaE

VanessaE commented Feb 17, 2017

The mapper returns tons and tons of errors of this nature:

Coordinates: -1120,16,-1552+16+16+16;  Cause: incorrect header check
Failed to decompress data in map block -70,0,-97 (id: -1627390022). Block corrupt ?
Coordinates: -1120,0,-1552+16+16+16;  Cause: incorrect header check
Failed to decompress data in map block -69,2,-97 (id: -1627381829). Block corrupt ?
Coordinates: -1104,32,-1552+16+16+16;  Cause: incorrect header check
Failed to decompress data in map block -69,1,-97 (id: -1627385925). Block corrupt ?
Coordinates: -1104,16,-1552+16+16+16;  Cause: incorrect header check
Exception: Too many block unpacking errors - bailing out

And it creates weirdly-sized/stretched/scaled images.

When I asked about this in #minetest-dev, I was told that the mapper needs "some changes" to work with current Minetest engine code. According to @sfan5, this commit is what led to the errors, minetest/minetest@f17c9c4, and this fixes it in upstream mapper, minetest@21444d0.

Making an equivalent change to your fork seems to fix the problem. Also, it would be a good idea to print the path to map.db (or map.sqlite) when throwing any kind of error. I run several mapper instances at once, each on a different world (to take advantage of multiple cores), and when an error happens, I can't tell which world it came from.

@enkidu-smith

This comment has been minimized.

enkidu-smith commented Feb 19, 2017

Probably related to this?

@adrido adrido referenced a pull request that will close this issue Feb 27, 2017

Open

Support for >=27 Mapblocks #20

@fireglow

This comment has been minimized.

fireglow commented Apr 3, 2017

Seeing that issue, too.

@LazyJ

This comment has been minimized.

LazyJ commented Apr 28, 2018

I've tested adrido's PR #20 with LinuxGaming's MT 0.4.14 (18gb world file) and MT 0.5.0-dev (1gb world file) and it works well with both.

I've been using Rogier-5's version of minetestmapper-cpp for several years now. His version has more features and has not been as problematic for me as the Minetest "official" version has during those same years.

So Rogier-5, if you happen to read this, please know that there are still folks who prefer to use your mapper and we sure would appreciate you keeping it maintained. Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment