Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Does not work properly with current minetest-dev #19
The mapper returns tons and tons of errors of this nature:
And it creates weirdly-sized/stretched/scaled images.
When I asked about this in #minetest-dev, I was told that the mapper needs "some changes" to work with current Minetest engine code. According to @sfan5, this commit is what led to the errors, minetest/minetest@f17c9c4, and this fixes it in upstream mapper, minetest@21444d0.
Making an equivalent change to your fork seems to fix the problem. Also, it would be a good idea to print the path to map.db (or map.sqlite) when throwing any kind of error. I run several mapper instances at once, each on a different world (to take advantage of multiple cores), and when an error happens, I can't tell which world it came from.
I've tested adrido's PR #20 with LinuxGaming's MT 0.4.14 (18gb world file) and MT 0.5.0-dev (1gb world file) and it works well with both.
I've been using Rogier-5's version of minetestmapper-cpp for several years now. His version has more features and has not been as problematic for me as the Minetest "official" version has during those same years.
So Rogier-5, if you happen to read this, please know that there are still folks who prefer to use your mapper and we sure would appreciate you keeping it maintained. Thanks ;)