Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: new.target #295

Merged
merged 2 commits into from Oct 31, 2018
Merged

n-api: new.target #295

merged 2 commits into from Oct 31, 2018

Conversation

legendecas
Copy link
Contributor

@legendecas legendecas commented Aug 14, 2018 •
edited

Checklist
  • npm test passes
  • tests included

Issues encountered in this PR:

@legendecas legendecas added this to In progress in Bootstrap N-API via automation Aug 14, 2018
@legendecas legendecas mentioned this pull request Aug 14, 2018
Closed
@legendecas legendecas changed the title napi: new.target polyfill [WIP] napi: new.target polyfill Aug 14, 2018
@legendecas legendecas mentioned this pull request Aug 14, 2018
Closed
9 tasks
@legendecas legendecas force-pushed the napi/new-target branch 3 times, most recently from b483648 to abc5404 Compare August 16, 2018 09:43
@yorkie yorkie removed this from In progress in Bootstrap N-API Aug 17, 2018
yorkie added a commit that referenced this pull request Oct 21, 2018
@yorkie
jerry: set proto/constructor for external functions
fea104f 
External functions are treated as incomplete creation, which prototype
is set to be undefined, which causes the `has_instance` doesn't work
at external function.

Fixes: #294
Activte: #295
@yorkie yorkie mentioned this pull request Oct 21, 2018
Merged
3 tasks
yorkie added a commit that referenced this pull request Oct 22, 2018
@yorkie
jerry: set prototype/constructor for external functions (#386)
48c9f78 
External functions are treated as incomplete creation, which prototype
is set to be undefined, which causes the `has_instance` doesn't work
at external function.

Fixes: #294
Activte: #295
yorkie added a commit that referenced this pull request Oct 24, 2018
@yorkie
jerry: set prototype/constructor for external functions (#386)
b8288b8 
External functions are treated as incomplete creation, which prototype
is set to be undefined, which causes the `has_instance` doesn't work
at external function.

Fixes: #294
Activte: #295
@legendecas legendecas changed the title [WIP] napi: new.target polyfill napi: new.target Oct 29, 2018
@legendecas
Copy link
Contributor Author

new.target has been implemented in N-API! /cc @yorkie @lolBig

@legendecas legendecas force-pushed the napi/new-target branch 10 times, most recently from 5fbd40c to 5eaece0 Compare October 29, 2018 10:00
@legendecas legendecas force-pushed the napi/new-target branch 7 times, most recently from 3196270 to b1867c3 Compare October 30, 2018 05:41
@legendecas legendecas changed the title napi: new.target n-api: new.target Oct 30, 2018
@yorkie
Copy link
Member

yorkie commented Oct 31, 2018

Our compatible list should be updated, too :p

yorkie
yorkie approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great works, LGTM if CI is green :)

@yorkie yorkie merged commit 50c8a19 into master Oct 31, 2018
@yorkie yorkie deleted the napi/new-target branch October 31, 2018 16:39
yorkie pushed a commit that referenced this pull request Nov 6, 2018
@legendecas @yorkie
n-api: implement new.target (#295)
bb06c0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorkie yorkie yorkie approved these changes

@algebrait algebrait Awaiting requested review from algebrait

@qile222 qile222 Awaiting requested review from qile222

Assignees
No one assigned
Labels
n-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@legendecas @yorkie