Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview observable with monitor lock #218

Merged
merged 4 commits into from
Apr 1, 2019
Merged

Preview observable with monitor lock #218

merged 4 commits into from
Apr 1, 2019

Conversation

Wouterdek
Copy link
Contributor

This pull request is the same as #199, except no reader-writer locks are used.
It also removes reader-writer locks from lists.
Related PRs: #199, #213, #211,
Related issue: #194

# Conflicts:
#	DynamicData/Kernel/InternalEx.cs
#	DynamicData/List/ChangeAwareList.cs
#	DynamicData/List/Internal/ReaderWriter.cs
@RolandPheasant
Copy link
Collaborator

This looks excellent. I will merge and do some additional sanity checking before the next release.

It will be beneficial to create a wiki page on the purpose of Preview and the use cases that it covers. Are you willing to write a wiki entry?

@RolandPheasant RolandPheasant merged commit df59361 into reactivemarbles:master Apr 1, 2019
@Wouterdek
Copy link
Contributor Author

Are you willing to write a wiki entry?

Done.

@Wouterdek Wouterdek deleted the PreviewObservableWithMonitorLock branch April 1, 2019 21:01
@RolandPheasant
Copy link
Collaborator

Awesome. Thanks very much

@lock lock bot locked and limited conversation to collaborators Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants