specs refactoring #38

Closed
EppO opened this Issue Feb 9, 2012 · 0 comments

Comments

Projects
None yet
1 participant
Member

EppO commented Feb 9, 2012

Along with #35, specs need a huge refactoring because they are really messy now. I intend to use RSpec best practices like in these 2 blog posts:
http://eggsonbread.com/2010/03/28/my-rspec-best-practices-and-tips/
http://blog.carbonfive.com/2010/10/21/rspec-best-practices/

EppO was assigned Feb 9, 2012

@EppO EppO added a commit that referenced this issue Feb 29, 2012

@EppO EppO started specs refactoring
it was actually a big mess, it's a lot more readable but I still need to apply rspec best practices
refs #38
78f4244

@EppO EppO added a commit that referenced this issue Mar 1, 2012

@EppO EppO heavy specs refactoring on going
split up the main role_spec.rb file into several files
config_spec.rb is the spec style I aim to use for now
added handy set_defaults method (more likely for specs use only)
refs #38
9b7ef7c

@EppO EppO added a commit that referenced this issue Mar 1, 2012

@EppO EppO refactoring of resource spec
refs #38
ebb1738

@EppO EppO added a commit that referenced this issue Mar 6, 2012

@EppO EppO keep refactoring specs: dynamic methods
refs #38
b32249c

@EppO EppO added a commit that referenced this issue Mar 23, 2012

@EppO EppO big specs refactoring
split up all shared examples in multiple files
use shared contexts heavily
test all methods with String or Symbol as role name parameter
refs #38
a8b9802

EppO closed this in 8c36304 Mar 24, 2012

EppO removed their assignment Jul 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment