Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes as per per the automated audit #25

Merged
merged 4 commits into from Jun 2, 2019

Conversation

Projects
None yet
2 participants
@AdmiringWorm
Copy link
Contributor

commented Apr 26, 2019

The changes in this PR is made as per the recommended changes detailed in the automated audit (#24)

What was changed

  • The icon url was changed from using rawgit, to use jsdelivr instead.
    The is more or less an obligatory change, as rawgit is shutting down, and jsdelivr is the recommended cdn to use for addins.
  • The dependency for Cake.Core was removed. This dependency was removed because Cake.Common already depends on Cake.Core and as such it will be pulled in during build.
  • Cake.Common was made an Private Asset. This change was mainly done because it is not needed to be listed as a dependency when pushing the package (Exactly why this is recommended to be set to private I do not know. This would be a question to the develops of Cake).
  • All Cake dependencies was updated to version 0.33.0, this is the recommended version to target, due to some breaking changes implemented in that version.
  • Cake.Common was added as a dependency to the Unit Testing library, without this dependency I was unable to build the projects (could possibly be one of the breaking changes in the latest version of Cake. Uncertain)
  • Added package configuration file to pin the version of cake used when building the project, this is only a recommended change and I can remove the change if desired.

/CC @Romanx

AdmiringWorm added some commits Apr 26, 2019

@Romanx

This comment has been minimized.

Copy link
Owner

commented Jun 2, 2019

Thank you very much for the contribution!

@Romanx Romanx merged commit 310d0dc into Romanx:master Jun 2, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@AdmiringWorm AdmiringWorm deleted the AdmiringWorm:update-cake-version branch Jun 2, 2019

Romanx added a commit that referenced this pull request Jun 2, 2019

Changes as per per the automated audit (#25)
* Removed unnedded dependency

* Added Cake.Common as a private asset

ref #24

* Updated cake dependencies to 0.33.0

ref #24"

* Updated package icon to use jsdelivr

fixes #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.