BureaucraticErrorEvent-Tweak

[imatsoup]

About the PR

Changed the logic behind the BureaucraticErrorEvent so that it can no longer close out job slots mid-round.

Why / Balance

Multiple individuals the past couple of days have expressed frustration at the current behavior of the event, and would prefer it could not close out job slots. Increasing them or making them infinite is deemed more entertaining than potentially locking someone out of the round. Incidentally, these changes also should prevent some unintended behavior where the event was reportedly closing out Passenger and other infinite roles.

Technical details

When the event is triggered, there is a 25% chance as it is currently implemented to close out all slots except a few, but make the remaining infinite. The for-loop used to remove those slots has been removed, leaving only the behavior of making some jobs infinite. The remaining 75% of the time, in the current implementation it chooses a number between -1 and 6, and modifies random job slots by that much. By changing the random range from -1-6 to 1-6, we remove the undesired situation of closing out job slots. Additionally, the event will always have some impact now by opening up additional slots no matter what, though still on random jobs. Lastly, the message text for the event is updated to reflect the new behavior of the event.

Media

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

🆑

• tweak: The Bureaucratic Error Event will no longer reduce the number of job slots or close out any particular job slot, only increase them or make them infinite.

[robinthedragon]

test fail is real, but unrelated

good tweak, removes the unfun part of the event while preserving the fun part

thank you for your first contribution :)