refactor: rename nova test dump #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator-instead-of-Model
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Nova test dump file naming convention to use a simpler, more consistent approach. Instead of generating dump files with complex names like nova_welcome_bonus_resource_dump.sql, the system now uses the simple dump.sql naming pattern inherited from the parent AbstractTestsGenerator class.
- Removed the
getDumpName()method override fromNovaTestGeneratorclass - Updated all test assertions to expect the simplified
dump.sqlfilename instead of entity-specific dump names - Aligned Nova test generator behavior with the standard test generator naming convention
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Generators/NovaTestGenerator.php | Removed the getDumpName() method override to use parent class's simple dump.sql naming convention |
| tests/NovaTestGeneratorTest.php | Updated test assertions to expect dump.sql instead of nova_welcome_bonus_resource_dump.sql |
| tests/CommandTest.php | Updated test assertions to expect dump.sql instead of nova_post_resource_dump.sql and nova_post_dump.sql |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DenTray
approved these changes
Nov 24, 2025
DenTray
deleted the
140-use-NovaResource-class-in-NovaTestGenerator-instead-of-Model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.