Skip to content

Rename variables that suggest that message is partial when it is not necessary #4087

@wkordalski

Description

@wkordalski

What problem does this proposed feature solve?

When we read Task class definition (earlier: Cline), and especially the Task.ask and Task.say methods,
we see they call Task.updateClineMessage when the message has changed (new chunk of data arrived from AI).

Task.updateClineMessage is called with both partial and complete messages. However the first parameter of Task.updateClineMessage is named partialMessage (suggesting it contains a partial message), and the function itself sends partialMessage message to webview.
This all confuse developers.

Describe the proposed solution in detail

The first parameter of Task.updateClineMessage should be named simply message or clineMessage.

The message name sent to webview should be updatePartialMessage, partialMessageUpdated or messageUpdated. And it should contain field message or clineMessage, but not partialMessage, because the field can store complete messages also.

Maybe we should rename Task.updateClineMessage to Task.updatePartialMessage, but I'm not convinced now.

It's only rename. But it can make reading the code of Roo-Code easier and limit the time when the developers are surprised and limit the number of introduced bugs.

Technical considerations or implementation details (optional)

No response

Describe alternatives considered (if any)

No response

Additional Context & Mockups

No response

Proposal Checklist

  • I have searched existing Issues and Discussions to ensure this proposal is not a duplicate.
  • This proposal is for a specific, actionable change intended for implementation (not a general idea).
  • I understand that this proposal requires review and approval before any development work begins.

Are you interested in implementing this feature if approved?

  • Yes, I would like to contribute to implementing this feature.

Metadata

Metadata

Assignees

Labels

Issue - In ProgressSomeone is actively working on this. Should link to a PR soon.enhancementNew feature or request

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions