Skip to content

Conversation

@feifei325
Copy link
Contributor

@feifei325 feifei325 commented Mar 17, 2025

Context

Some keys were found that have not been internationalized in the code. To address this, I added a script to help users check if all internationalization keys in the code exist in the language configuration files. The script will scan the code for internationalization keys and compare them with the entries in the language configuration files to ensure that every required key is covered.

Implementation

Screenshots

before after

How to Test

  1. Run the node scripts/find-missing-i18n-key.js script to find any un-internationalized keys.
  2. Ensure that every un-internationalized key is properly added to the corresponding language configuration file.
  3. Perform regular testing to ensure the new internationalization keys are loaded and displayed correctly.

Get in Touch


Important

Add script to find missing i18n keys and update language files with new keys, fixing a missing key in ChatView.tsx.

  • Scripts:
    • Add find-missing-i18n-key.js script to scripts/ to identify missing i18n keys by comparing code with language files.
    • Supports options for specific locale and file checks.
  • Language Files:
    • Update settings.json in locales/ca, locales/de, locales/en, locales/es, locales/fr, locales/hi, locales/it, locales/ja, locales/ko, locales/pl, locales/pt-BR, locales/tr, locales/vi, locales/zh-CN, locales/zh-TW to add missing i18n keys.
  • Components:
    • Fix missing settings key in ChatView.tsx by changing t("chat:completeSubtaskAndReturn.title") to t("chat:completeSubtaskAndReturn").

This description was created by Ellipsis for 73d7bcb8ab454ac7b8b2ccdf4bceb12cb01c6044. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2025

⚠️ No Changeset found

Latest commit: fddb611

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 17, 2025
@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Mar 17, 2025

The pull request includes changes across 18 files, with 448 lines added and 1 line removed. The changes are primarily focused on adding new localization keys for various languages and introducing a script for finding missing i18n keys. These changes are interconnected as the script supports the localization effort by identifying missing keys. Therefore, it seems appropriate to keep these changes in a single pull request as they serve a unified purpose.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an exact duplicate of the existing findKeys function. Consider reusing the existing implementation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key newProfile uses the text '新建配置檔案', whereas other similar keys use '設定檔'. Consider using consistent terminology (e.g., '新建設定檔') unless the difference is intentional.

Suggested change
"newProfile": "新建配置檔案",
"newProfile": "新建設定檔",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Signed-off-by: feifei <liuyansheng1121@gmail.com>
@feifei325 feifei325 force-pushed the i18n/fix_missing_settings_key branch from 73d7bcb to fddb611 Compare March 17, 2025 16:46
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 17, 2025
@mrubens mrubens merged commit 01a847e into RooCodeInc:main Mar 17, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants