-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix missing settings key and add find i18n key scripts #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix missing settings key and add find i18n key scripts #1738
Conversation
|
|
The pull request includes changes across 18 files, with 448 lines added and 1 line removed. The changes are primarily focused on adding new localization keys for various languages and introducing a script for finding missing i18n keys. These changes are interconnected as the script supports the localization effort by identifying missing keys. Therefore, it seems appropriate to keep these changes in a single pull request as they serve a unified purpose. |
scripts/find-missing-i18n-key.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an exact duplicate of the existing findKeys function. Consider reusing the existing implementation.
- function
findKeys(find-missing-translations.js)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key newProfile uses the text '新建配置檔案', whereas other similar keys use '設定檔'. Consider using consistent terminology (e.g., '新建設定檔') unless the difference is intentional.
| "newProfile": "新建配置檔案", | |
| "newProfile": "新建設定檔", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Signed-off-by: feifei <liuyansheng1121@gmail.com>
73d7bcb to
fddb611
Compare
Context
Some keys were found that have not been internationalized in the code. To address this, I added a script to help users check if all internationalization keys in the code exist in the language configuration files. The script will scan the code for internationalization keys and compare them with the entries in the language configuration files to ensure that every required key is covered.
Implementation
Screenshots
How to Test
node scripts/find-missing-i18n-key.jsscript to find any un-internationalized keys.Get in Touch
Important
Add script to find missing i18n keys and update language files with new keys, fixing a missing key in
ChatView.tsx.find-missing-i18n-key.jsscript toscripts/to identify missing i18n keys by comparing code with language files.settings.jsoninlocales/ca,locales/de,locales/en,locales/es,locales/fr,locales/hi,locales/it,locales/ja,locales/ko,locales/pl,locales/pt-BR,locales/tr,locales/vi,locales/zh-CN,locales/zh-TWto add missing i18n keys.ChatView.tsxby changingt("chat:completeSubtaskAndReturn.title")tot("chat:completeSubtaskAndReturn").This description was created by
for 73d7bcb8ab454ac7b8b2ccdf4bceb12cb01c6044. It will automatically update as commits are pushed.