Clean up CSS for settings view wheel scroll #1750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7d1d558 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:S
cte
force-pushed
the
cte/settings-scroll-cleanup
branch
from
e8b319d to
7d1d558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We can get away with less CSS here, and if possible we shouldn't hardcode heights.
Implementation
Screenshots
How to Test
Get in Touch
Important
Simplified CSS for
SettingsViewinSettingsView.tsxby removing hardcoded properties and improving scroll handling.maxHeight,height,overflowY,overflowX,position,display,scrollbarWidth, andwillChangeproperties fromTabContentinSettingsView.tsx.will-change-scrollclass toTabContentfor smoother scrolling.onWheelevent inSettingsView.tsxto directly adjustscrollTop..changeset/cyan-owls-juggle.mdto reflect the fix for scrolling in the VSCode editor tab.This description was created by
for 7d1d558. It will automatically update as commits are pushed.