Skip to content

Clean up CSS for settings view wheel scroll #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Clean up CSS for settings view wheel scroll #1750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cyan-owls-juggle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"roo-cline": patch
---

Fix SettingsView scrolling in VSCode editor tab
15 changes: 2 additions & 13 deletions webview-ui/src/components/settings/SettingsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,24 +338,13 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone },
</TabHeader>

<TabContent
className="p-0 divide-y divide-vscode-sideBar-background"
className="p-0 divide-y divide-vscode-sideBar-background will-change-scroll"
style={{
maxHeight: "calc(100vh - 6rem)",
height: "calc(100vh - 6rem)",
overflowY: "scroll",
overflowX: "hidden",
WebkitOverflowScrolling: "touch",
position: "relative",
display: "block",
msOverflowStyle: "-ms-autohiding-scrollbar",
scrollbarWidth: "auto",
scrollbarGutter: "stable",
willChange: "scroll-position",
}}
onWheel={(e) => {
const container = e.currentTarget
container.scrollTop += e.deltaY
}}
onWheel={(e) => (e.currentTarget.scrollTop += e.deltaY)}
onScroll={handleScroll}>
<div ref={providersRef}>
<SectionHeader>
Expand Down