Skip to content

Do a little code cleanup now that tools are refactored out #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2025
Merged

Do a little code cleanup now that tools are refactored out #2103

merged 1 commit into from
Mar 30, 2025

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Mar 30, 2025 •
edited by ellipsis-dev bot
Loading

Important

Clean up Cline.ts by removing unused imports and simplifying switch cases for better readability.

  • Imports:
    • Removed unused imports: extractTextFromFile, addLineNumbers, stripLineNumbers, everyLineHasLineNumbers, countFileLines, regexSearchFiles, parseSourceCodeDefinitionsForFile, parseSourceCodeForDefinitionsTopLevel, BrowserAction, BrowserActionResult, browserActions, ClineAskUseMcpServer, ClineSayBrowserAction, ClineSayTool, detectCodeOmission, insertGroups, parseXml, isPathOutsideWorkspace, getReadablePath.
  • Switch Cases:
    • Simplified switch cases in Cline class by removing unnecessary braces in case statements for search_files, browser_action, execute_command, use_mcp_tool, access_mcp_resource, ask_followup_question, switch_mode, new_task, attempt_completion.

This description was created by Ellipsis for b2b79f0. It will automatically update as commits are pushed.

@mrubens mrubens requested a review from cte as a code owner March 30, 2025 06:04
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 30, 2025
@mrubens mrubens merged commit 87b0647 into main Mar 30, 2025
15 checks passed
@mrubens mrubens deleted the cline_code_cleanup branch March 30, 2025 06:07
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 30, 2025
Smartsheet-JB-Brown added a commit to Smartsheet-JB-Brown/Roo-Code that referenced this pull request Mar 30, 2025
@Smartsheet-JB-Brown
Merge branch 'main' into jbbrown/bedrock_caching
a85b697 
* main: (29 commits)
  Link to provider docs from the API options (RooCodeInc#2112)
  Link to the settings page from the auto approve toolbar (RooCodeInc#2111)
  Remove the ask promise error (RooCodeInc#2107)
  i18n Add translations for task pinning and unpinning (RooCodeInc#2109)
  Clean up the way we compute the current diff strategy (RooCodeInc#2049)
  Do a little code cleanup now that tools are refactored out (RooCodeInc#2103)
  Move new_task, switch_mode, attempt_completion, and ask_followup_question to tool files (RooCodeInc#2102)
  Move use_mcp_tool and access_mcp_resource to tool files (RooCodeInc#2101)
  Move execute_command to a tool file (RooCodeInc#2100)
  Move browser_action to a tool file (RooCodeInc#2099)
  Move search_files to a tool file (RooCodeInc#2098)
  Move list_code_definition_names to a tool file (RooCodeInc#2097)
  Move search_and_replace to a tool file (RooCodeInc#2096)
  Move insert_content to a tool file (RooCodeInc#2095)
  Move apply_diff to a tool file (RooCodeInc#2094)
  Move write_to_file to a tool file (RooCodeInc#2093)
  Fix a type in the listFiles tool (RooCodeInc#2092)
  Remove switch from tools (RooCodeInc#2091)
  Refactor/cline.ts/list files (RooCodeInc#2067)
  Update contributors list (RooCodeInc#2089)
  ...
cte pushed a commit that referenced this pull request Mar 30, 2025
@mrubens @cte
Do a little code cleanup now that tools are refactored out (#2103)
573fd6b
cte added a commit that referenced this pull request Mar 30, 2025
@cte @gtaylor
@hannesrudolph @mrubens @aheizi @afshawnlotfi @nbihan-mediware @github-actions @bramburn @feifei325
Parallel tasks (#2128)
4f683b5 
* Parallel tasks

* Handle null [x]ModelInfo types, recover from settings schema parse errors (#2064)

* Require exactly node v20.18.1 (#2065)

* Get rid of runner and all CJS stuff

* Add an activation command for other extensions (#2073)

Since VS Code provides no actionEvents that trigger when a specific
extension activates, extensions can't activate only once Roo is
activated and ready.

This commit introduces a new roo-cline.activationCompleted command
and fires it at the very end of extension activation. Other
extensions that use Roo's exported APIs can now activate when they
see this event.

Co-authored-by: Greg Taylor <gregtaylor@netflix.com>

* Update bug_report.yml (#1994)

* Update bug_report.yml

* Update bug_report.yml

---------

Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>

* Fix mention file name is not fully displayed (#2026)

Fixed path leading character handling to preserve language characters and remove specific punctuation marks

* In-Editor Browser Improvements (#1601)

* Browser Automation Improvements
* Added multi-tab remote Chrome support
* Added support for hover
* Properly caching remote browser host in global state
* Cleanup functions

* Updated for changes after merge

* Added www. exception for common tabs

* Update src/core/webview/ClineProvider.ts

* Revert README changes

---------

Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>

* Add missing awaits on refactored tools (#2078)

* More progress

* Added Gemini 2.5 Pro model to GCP Vertex AI Provider (#2079)

* More progress

* Display info about partial reads in chat row (#2080)

* More progress

* Update contributors list (#2023)

docs: update contributors list [skip ci]

Co-authored-by: mrubens <mrubens@users.noreply.github.com>

* More progress

* Handle multiple API pages worth of contributors (#2088)

* Update contributors list (#2089)

docs: update contributors list [skip ci]

Co-authored-by: mrubens <mrubens@users.noreply.github.com>

* Refactor/cline.ts/list files (#2067)

* "Refactor list_files tool to separate module (#2057)"

* Await

---------

Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>

* Remove switch from tools (#2091)

* HandleError returns a promise

* Remove unnecessary switch from tools

* Fix a type in the listFiles tool (#2092)

* Move write_to_file to a tool file (#2093)

* Move apply_diff to a tool file (#2094)

* Move insert_content to a tool file (#2095)

* Move search_and_replace to a tool file (#2096)

* Move list_code_definition_names to a tool file (#2097)

* Move search_files to a tool file (#2098)

* Move browser_action to a tool file (#2099)

* Move execute_command to a tool file (#2100)

* Move use_mcp_tool and access_mcp_resource to tool files (#2101)

* Move new_task, switch_mode, attempt_completion, and ask_followup_question to tool files (#2102)

* Do a little code cleanup now that tools are refactored out (#2103)

* Clean up the way we compute the current diff strategy (#2049)

* Clean up the way we compute the current diff strategy

* Add changeset

* i18n Add translations for task pinning and unpinning (#2109)

Signed-off-by: feifei <liuyansheng1121@gmail.com>

* Remove the ask promise error (#2107)

* Remove the ask promise error

* Send start_time along with checkpoints and use it to position in the messages

* Link to the settings page from the auto approve toolbar (#2111)

* Link to provider docs from the API options (#2112)

* Revert "Remove the ask promise error" (#2117)

Revert "Remove the ask promise error (#2107)"

This reverts commit 712ca71.

* Parse the retry out of the gemini 429 response (#2118)

* Fix Gemini command escaping (#2120)

* Fix switching profiles to ensure only the selected profile is switche… (#2119)

Fix switching profiles to ensure only the selected profile is switched for all modes, and optimize certain i18n keys.

Signed-off-by: feifei <liuyansheng1121@gmail.com>

* Tweaks to support prompt line number format (#2121)

* Remove the ask promise error (#2123)

* Stronger typing

* Added Gemini 2.5 Pro model to GCP Vertex AI Provider (#2079)

* Display info about partial reads in chat row (#2080)

* Update contributors list (#2023)

docs: update contributors list [skip ci]

Co-authored-by: mrubens <mrubens@users.noreply.github.com>

* Handle multiple API pages worth of contributors (#2088)

* Update contributors list (#2089)

docs: update contributors list [skip ci]

Co-authored-by: mrubens <mrubens@users.noreply.github.com>

* Refactor/cline.ts/list files (#2067)

* "Refactor list_files tool to separate module (#2057)"

* Await

---------

Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>

* Remove switch from tools (#2091)

* HandleError returns a promise

* Remove unnecessary switch from tools

* Fix a type in the listFiles tool (#2092)

* Move write_to_file to a tool file (#2093)

* Move apply_diff to a tool file (#2094)

* Move insert_content to a tool file (#2095)

* Move search_and_replace to a tool file (#2096)

* Move list_code_definition_names to a tool file (#2097)

* Move search_files to a tool file (#2098)

* Move browser_action to a tool file (#2099)

* Move execute_command to a tool file (#2100)

* Move use_mcp_tool and access_mcp_resource to tool files (#2101)

* Move new_task, switch_mode, attempt_completion, and ask_followup_question to tool files (#2102)

* Do a little code cleanup now that tools are refactored out (#2103)

* Clean up the way we compute the current diff strategy (#2049)

* Clean up the way we compute the current diff strategy

* Add changeset

* i18n Add translations for task pinning and unpinning (#2109)

Signed-off-by: feifei <liuyansheng1121@gmail.com>

* Remove the ask promise error (#2107)

* Remove the ask promise error

* Send start_time along with checkpoints and use it to position in the messages

* Link to the settings page from the auto approve toolbar (#2111)

* Link to provider docs from the API options (#2112)

* Revert "Remove the ask promise error" (#2117)

Revert "Remove the ask promise error (#2107)"

This reverts commit 712ca71.

* Parse the retry out of the gemini 429 response (#2118)

* Fix Gemini command escaping (#2120)

* Fix switching profiles to ensure only the selected profile is switche… (#2119)

Fix switching profiles to ensure only the selected profile is switched for all modes, and optimize certain i18n keys.

Signed-off-by: feifei <liuyansheng1121@gmail.com>

* Tweaks to support prompt line number format (#2121)

* Remove the ask promise error (#2123)

* Pass along pid and ppid

* Revert "Remove the ask promise error" (#2126)

Revert "Remove the ask promise error (#2123)"

This reverts commit b788aa1.

---------

Signed-off-by: feifei <liuyansheng1121@gmail.com>
Co-authored-by: Greg Taylor <gtaylor@users.noreply.github.com>
Co-authored-by: Greg Taylor <gregtaylor@netflix.com>
Co-authored-by: Hannes Rudolph <hrudolph@gmail.com>
Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
Co-authored-by: aheizi <aheizi@outlook.com>
Co-authored-by: Afshawn Lotfi <6283745+afshawnlotfi@users.noreply.github.com>
Co-authored-by: Nico Bihan <nicolas.bihan@wellsky.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bhavesh Ramburn <nitrogen@gmail.com>
Co-authored-by: feifei <46489071+feifei325@users.noreply.github.com>
monotykamary pushed a commit to monotykamary/Roo-Code that referenced this pull request Apr 4, 2025
@celestial-vault
Remove legacy anthropic tool use code from mistral-format (RooCodeInc…
33f9472 
…#2103)

* remove claude tool use backwards compatability

* remove anthropic tool use from mistal-format

* further simplify mistral-format

* fix linting error in unrelated file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cte cte Awaiting requested review from cte cte is a code owner

Assignees

No one assigned

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrubens