From 0701a9d57cff4eac7d9692ced4eafe97c94a2313 Mon Sep 17 00:00:00 2001 From: Eric Wheeler Date: Thu, 22 May 2025 22:30:49 -0700 Subject: [PATCH] fix: respect user-configured terminal integration timeout The terminal integration timeout was being capped at the default value of 5 seconds due to a Math.min call in getShellIntegrationTimeout(), preventing users from setting longer timeouts. This caused shell integration to fail prematurely when initialization took longer than 5 seconds. This change removes the Math.min cap, allowing the user-configured timeout value to be respected. Fixes: #3885 Fixes: #3829 Regression from: #2820 Signed-off-by: Eric Wheeler --- src/integrations/terminal/BaseTerminal.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/integrations/terminal/BaseTerminal.ts b/src/integrations/terminal/BaseTerminal.ts index 88e9b0f3aa..8137881b8c 100644 --- a/src/integrations/terminal/BaseTerminal.ts +++ b/src/integrations/terminal/BaseTerminal.ts @@ -170,7 +170,7 @@ export abstract class BaseTerminal implements RooTerminal { } public static getShellIntegrationTimeout(): number { - return Math.min(BaseTerminal.shellIntegrationTimeout, BaseTerminal.defaultShellIntegrationTimeout) + return BaseTerminal.shellIntegrationTimeout } public static setShellIntegrationDisabled(disabled: boolean): void {