Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback style #8

Closed
roberrrt-s opened this issue Nov 25, 2019 · 1 comment

Comments

@roberrrt-s
Copy link

@roberrrt-s roberrrt-s commented Nov 25, 2019

Hi Roy, Ik heb vrijwel geen feedback, want het ziet er allemaal erg goed uit, ik zou alleen zien dat je je code beter indenteert, want nu zijn er hier en daar wat rare quirks te zien qua hoeveelheid tabs/spaties. Je kunt je code even door een beautifier halen om dat recht te trekken, kijk verder ook nog even naar de consistentie van () => {} en function(d) {} want die gebruik je nu door elkaar.

(d3.hierarchy({children: data})
  .sum(d => d.categoryAmount));

Volgens mij hoeven hier geen () omheen.
Veel succes verder

@RooyyDoe

This comment has been minimized.

Copy link
Owner

@RooyyDoe RooyyDoe commented Nov 26, 2019

Dankjewel Robert

@RooyyDoe RooyyDoe closed this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.