Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick only relevant form fields when saving program #119

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@LisaManresa
Copy link
Contributor

LisaManresa commented Nov 5, 2019

  • Add the Clubhouse Story ID: [ch21294]
  • Add QA tasks
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #119 into develop will increase coverage by 9.36%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #119      +/-   ##
===========================================
+ Coverage    84.67%   94.03%   +9.36%     
===========================================
  Files          104      104              
  Lines         1853     1862       +9     
===========================================
+ Hits          1569     1751     +182     
+ Misses         284      111     -173
Impacted Files Coverage Δ
src/js/apps/admin/sidebar/program-sidebar_app.js 100% <100%> (+100%) ⬆️
src/js/apps/patients/view/view_app.js 0% <0%> (-90%) ⬇️
src/js/views/patients/view/view_views.js 12.82% <0%> (-74.36%) ⬇️
src/js/entities-service/actions.js 66.66% <0%> (-33.34%) ⬇️
src/js/views/globals/app-nav/app-nav_views.js 81.25% <0%> (-18.75%) ⬇️
src/js/apps/patients/patients-main_app.js 84.61% <0%> (-15.39%) ⬇️
src/js/apps/globals/nav_app.js 93.18% <0%> (-4.55%) ⬇️
src/js/components/optionlist/index.js 95.83% <0%> (-4.17%) ⬇️
src/js/base/collection.js 100% <0%> (ø) ⬆️
.../apps/patients/patient/dashboard/add-action_app.js 100% <0%> (ø) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f191c...c55f1c1. Read the comment docs.

@cypress

This comment has been minimized.

Copy link

cypress bot commented Nov 5, 2019



Test summary

61 0 0 0


Run details

Project RoundingWell Care Ops Frontend
Status Passed
Commit c55f1c1
Started Nov 5, 2019 7:27 PM
Ended Nov 5, 2019 7:28 PM
Duration 01:09 💡
OS Linux Debian - 9.6
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

paulfalgout left a comment

can we check the test for the name/details patch to make sure that it doesn't include published?

@LisaManresa LisaManresa force-pushed the bugfix/program-state-persistence branch from 589f985 to c55f1c1 Nov 5, 2019
Copy link
Member

luketlancaster left a comment

:shipit: 🕺

@paulfalgout paulfalgout merged commit 6bcdde4 into develop Nov 5, 2019
3 checks passed
3 checks passed
Automated Preview AWS pull request preview
Details
cypress: care ops 61 tests passed in 01:02
Details
test-deploy Workflow: test-deploy
Details
@paulfalgout paulfalgout deleted the bugfix/program-state-persistence branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.