Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch program along with action activity for sidebar #120

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@luketlancaster
Copy link
Member

luketlancaster commented Nov 5, 2019

  • Add the Clubhouse Story ID: [ch21282]
@luketlancaster

This comment has been minimized.

Copy link
Member Author

luketlancaster commented Nov 5, 2019

this one'll wait on #121 so those changes can go in here

@@ -45,7 +45,7 @@ module.exports = {
};

return {
relationships: _.clone(baseRelationships),
relationships,

This comment has been minimized.

Copy link
@paulfalgout

paulfalgout Nov 5, 2019

Member

oh whoops

This comment has been minimized.

Copy link
@luketlancaster

luketlancaster Nov 5, 2019

Author Member

right?

Copy link
Member

paulfalgout left a comment

👍 yep we'll just update this after the fetch fix, but it looks GTG.

@cypress

This comment has been minimized.

Copy link

cypress bot commented Nov 5, 2019



Test summary

61 0 0 0


Run details

Project RoundingWell Care Ops Frontend
Status Passed
Commit 6c83de7
Started Nov 5, 2019 7:11 PM
Ended Nov 5, 2019 7:12 PM
Duration 01:02 💡
OS Linux Debian - 9.6
Browser Electron 73

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 5, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (develop@0c84de5). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #120   +/-   ##
==========================================
  Coverage           ?   76.75%           
==========================================
  Files              ?      104           
  Lines              ?     1876           
  Branches           ?        0           
==========================================
  Hits               ?     1440           
  Misses             ?      436           
  Partials           ?        0
Impacted Files Coverage Δ
src/js/entities-service/entities/events.js 33.33% <0%> (ø)
...ts/sidebar/action/action-sidebar-activity-views.js 54.54% <50%> (ø)
src/js/entities-service/programs.js 83.33% <80%> (ø)
src/js/apps/patients/sidebar/action-sidebar_app.js 57.69% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c84de5...6c83de7. Read the comment docs.

@luketlancaster luketlancaster force-pushed the feature/ch21282-program-action-assigned-event branch from 5c82684 to 6c83de7 Nov 5, 2019
@luketlancaster

This comment has been minimized.

Copy link
Member Author

luketlancaster commented Nov 5, 2019

alrighty, all updated with the new hotness @paulfalgout

@paulfalgout paulfalgout merged commit 22f191c into develop Nov 5, 2019
3 checks passed
3 checks passed
Automated Preview AWS pull request preview
Details
cypress: care ops 61 tests passed in 00:56
Details
test-deploy Workflow: test-deploy
Details
@paulfalgout paulfalgout deleted the feature/ch21282-program-action-assigned-event branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.