Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Chore/parallel requests #123
In addition to changing group clinicians in the bootstrap and patient fields to parallel requests, I looked at entity requests as a whole and tried to standardize naming and functionality. In some places we were passing the entity to get the id and some places we were passing the id, and in those cases we didn't have the entity, so the id everywhere is probably best.
Also I found a minor bug in the model/collection fetch change we just merged. It was aborting calls based on the root url of the entity.. so when we fetched clinicians in the bootstrap it was aborting the
Finally the patient-actions request wasn't setting up the filter quite right, so this'll be a bug in that epic until this gets in, but I also modified the style such that changing that on its own would be conflicting.
We're using so many url options that it is the primary url that should be registered. Also we're no longer using success, which isn't a problem because 100% of the usage of this had it anyhow.
@@ Coverage Diff @@ ## develop #123 +/- ## =========================================== + Coverage 96.22% 98.26% +2.04% =========================================== Files 104 104 Lines 1853 1847 -6 =========================================== + Hits 1783 1815 +32 + Misses 70 32 -38
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard