Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/parallel requests #123

Merged
merged 7 commits into from Nov 6, 2019

Conversation

@paulfalgout
Copy link
Member

paulfalgout commented Nov 6, 2019

  • Add the Clubhouse Story ID: [ch21286]

In addition to changing group clinicians in the bootstrap and patient fields to parallel requests, I looked at entity requests as a whole and tried to standardize naming and functionality. In some places we were passing the entity to get the id and some places we were passing the id, and in those cases we didn't have the entity, so the id everywhere is probably best.

Also I found a minor bug in the model/collection fetch change we just merged. It was aborting calls based on the root url of the entity.. so when we fetched clinicians in the bootstrap it was aborting the clinicians/me request due to the root url of the clinician model being the same. So now the xhr control uses the url when we override it and it was modified along with recent changes which no longer use a success callback.

Finally the patient-actions request wasn't setting up the filter quite right, so this'll be a bug in that epic until this gets in, but I also modified the style such that changing that on its own would be conflicting.

paulfalgout added 6 commits Nov 6, 2019
We're using so many url options that it is the primary url that should be registered. Also we're no longer using success, which isn't a problem because 100% of the usage of this had it anyhow.
Also updates bootstrap to use `beforeStart`
The program action filter wasn't correct and we can use the url on the collection
When we require parallel calls we can new route creation.
In some cases we can use returning includes to cheat relationships that would otherwise be nearly impossible to maintain.
@paulfalgout paulfalgout requested a review from luketlancaster Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #123 into develop will increase coverage by 2.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #123      +/-   ##
===========================================
+ Coverage    96.22%   98.26%   +2.04%     
===========================================
  Files          104      104              
  Lines         1853     1847       -6     
===========================================
+ Hits          1783     1815      +32     
+ Misses          70       32      -38
Impacted Files Coverage Δ
src/js/entities-service/groups.js 100% <ø> (ø) ⬆️
src/js/base/control.js 100% <ø> (ø) ⬆️
.../apps/patients/patient/dashboard/add-action_app.js 100% <ø> (ø) ⬆️
...rc/js/entities-service/entities/program-actions.js 100% <ø> (ø) ⬆️
src/js/entities-service/patients.js 100% <ø> (ø) ⬆️
...ps/patients/patient/data-events/data-events_app.js 100% <100%> (+100%) ⬆️
...c/js/apps/admin/program/workflows/workflows_app.js 100% <100%> (ø) ⬆️
src/js/base/model.js 100% <100%> (ø) ⬆️
...s/apps/patients/patient/dashboard/dashboard_app.js 100% <100%> (ø) ⬆️
src/js/base/collection.js 100% <100%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bcdde4...e93b383. Read the comment docs.

@paulfalgout

This comment has been minimized.

Copy link
Member Author

paulfalgout commented Nov 6, 2019

tests are timing out in different places on cypress... going to see if I can determine why it's stalling... :-/

@cypress

This comment has been minimized.

Copy link

cypress bot commented Nov 6, 2019



Test summary

61 0 0 0


Run details

Project RoundingWell Care Ops Frontend
Status Passed
Commit e93b383
Started Nov 6, 2019 3:32 PM
Ended Nov 6, 2019 3:34 PM
Duration 01:29 💡
OS Linux Debian - 9.6
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

luketlancaster left a comment

looks good to me. Request names are much clearer now/have consistency that should be easier for me to follow

@paulfalgout

This comment has been minimized.

Copy link
Member Author

paulfalgout commented Nov 6, 2019

Well good news/bad news Good news is reverting cypress consistently fixes the test hanging issue which is also the bad news.

@paulfalgout

This comment has been minimized.

Copy link
Member Author

paulfalgout commented Nov 6, 2019

I'm watching this and might try and debug it some if there's time cypress-io/cypress#5581

@paulfalgout paulfalgout merged commit 676f600 into develop Nov 6, 2019
5 checks passed
5 checks passed
Automated Preview AWS pull request preview
Details
codecov/patch 100% of diff hit (target 96.22%)
Details
codecov/project 98.26% (+2.04%) compared to 6bcdde4
Details
cypress: care ops 61 tests passed in 01:21
Details
test-deploy Workflow: test-deploy
Details
@paulfalgout paulfalgout deleted the chore/parallel-requests branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.