Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim program, program-action, and action names in validation #125

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@luketlancaster
Copy link
Member

luketlancaster commented Nov 6, 2019

  • Add the Clubhouse Story ID: [ch21333]
@luketlancaster luketlancaster requested a review from paulfalgout Nov 6, 2019
@cypress

This comment has been minimized.

Copy link

cypress bot commented Nov 6, 2019



Test summary

61 0 0 0


Run details

Project RoundingWell Care Ops Frontend
Status Passed
Commit e2926b2
Started Nov 6, 2019 7:22 PM
Ended Nov 6, 2019 7:23 PM
Duration 01:11 💡
OS Linux Debian - 9.6
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #125 into develop will increase coverage by 3.68%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
+ Coverage    94.58%   98.26%   +3.68%     
===========================================
  Files          104      104              
  Lines         1847     1847              
===========================================
+ Hits          1747     1815      +68     
+ Misses         100       32      -68
Impacted Files Coverage Δ
src/js/entities-service/entities/actions.js 100% <100%> (ø) ⬆️
src/js/entities-service/entities/programs.js 100% <100%> (ø) ⬆️
...rc/js/entities-service/entities/program-actions.js 100% <100%> (ø) ⬆️
src/js/views/globals/root_views.js 93.12% <0%> (+0.76%) ⬆️
src/js/apps/globals/nav_app.js 100% <0%> (+2.27%) ⬆️
...iews/patients/patient/dashboard/dashboard_views.js 100% <0%> (+2.77%) ⬆️
.../patients/patient/data-events/data-events_views.js 100% <0%> (+3.84%) ⬆️
src/js/components/optionlist/index.js 100% <0%> (+4.16%) ⬆️
src/js/components/datepicker/datepicker_views.js 100% <0%> (+6.66%) ⬆️
src/js/apps/patients/view/view_app.js 100% <0%> (+10%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e1103...e2926b2. Read the comment docs.

@paulfalgout paulfalgout merged commit 7474c8f into develop Nov 6, 2019
5 checks passed
5 checks passed
Automated Preview AWS pull request preview
Details
codecov/patch 100% of diff hit (target 94.58%)
Details
codecov/project 98.26% (+3.68%) compared to 40e1103
Details
cypress: care ops 61 tests passed in 01:03
Details
test-deploy Workflow: test-deploy
Details
@paulfalgout paulfalgout deleted the fix/ch21333-validate-empty-strings branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.