Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out initial action created event if action created from program #129

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@luketlancaster
Copy link
Member

luketlancaster commented Nov 7, 2019

  • Add the Clubhouse Story ID: [ch21350]
@@ -511,7 +512,7 @@ context('action sidebar', function() {

cy
.get('[data-activity-region]')
.should('contain', 'RoundingWell (System) added this Action')
.should('not.contain', 'RoundingWell (System) added this Action')
.should('contain', 'Clinician McTester (Nurse) changed the Owner to Another Clinician')
.should('contain', 'Clinician McTester (Nurse) changed the details of this Action')
.should('contain', 'Clinician McTester (Nurse) changed the Due Date to ')

This comment has been minimized.

Copy link
@luketlancaster

luketlancaster Nov 7, 2019

Author Member

you think we need a whole 'nother set of tests for a non-program action?

This comment has been minimized.

Copy link
@paulfalgout

paulfalgout Nov 7, 2019

Member

was that the only test for RoundingWell (System) cause I don't want to lose that. But yeah we probably should have another set of tests for the other option.. 1 for code coverage, but 2 .should('not.contain', 'Whatever') would also pass.. really we could probably add a test for an action with a program and have 2 events.. one create and the other the pathway one and then check for length of 1.

This comment has been minimized.

Copy link
@luketlancaster

luketlancaster Nov 8, 2019

Author Member

alrighty, I added another round for 'created by program action'. take a look and lemme know

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #129 into master will decrease coverage by 0.86%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #129      +/-   ##
=========================================
- Coverage   98.26%   97.4%   -0.87%     
=========================================
  Files         104     104              
  Lines        1847    1849       +2     
=========================================
- Hits         1815    1801      -14     
- Misses         32      48      +16
Impacted Files Coverage Δ
src/js/apps/patients/sidebar/action-sidebar_app.js 95.23% <100%> (-4.77%) ⬇️
...ts/sidebar/action/action-sidebar-activity-views.js 100% <100%> (ø) ⬆️
src/js/entities-service/entities/actions.js 86.66% <0%> (-13.34%) ⬇️
src/js/entities-service/entities/events.js 91.66% <0%> (-8.34%) ⬇️
src/js/views/patients/actions/actions_views.js 91.89% <0%> (-8.11%) ⬇️
...ws/patients/sidebar/action/action-sidebar_views.js 94.73% <0%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc1fb6...230597c. Read the comment docs.

@cypress

This comment has been minimized.

Copy link

cypress bot commented Nov 7, 2019



Test summary

61 0 0 0


Run details

Project RoundingWell Care Ops Frontend
Status Passed
Commit 230597c
Started Nov 8, 2019 5:53 PM
Ended Nov 8, 2019 5:54 PM
Duration 01:19 💡
OS Linux Debian - 9.6
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@@ -511,7 +512,7 @@ context('action sidebar', function() {

cy
.get('[data-activity-region]')
.should('contain', 'RoundingWell (System) added this Action')
.should('not.contain', 'RoundingWell (System) added this Action')
.should('contain', 'Clinician McTester (Nurse) changed the Owner to Another Clinician')
.should('contain', 'Clinician McTester (Nurse) changed the details of this Action')
.should('contain', 'Clinician McTester (Nurse) changed the Due Date to ')

This comment has been minimized.

Copy link
@paulfalgout

paulfalgout Nov 7, 2019

Member

was that the only test for RoundingWell (System) cause I don't want to lose that. But yeah we probably should have another set of tests for the other option.. 1 for code coverage, but 2 .should('not.contain', 'Whatever') would also pass.. really we could probably add a test for an action with a program and have 2 events.. one create and the other the pathway one and then check for length of 1.

@luketlancaster luketlancaster force-pushed the fix/ch21350-action-created-event-dupe branch from 52196e9 to e028b66 Nov 8, 2019
@luketlancaster luketlancaster requested a review from paulfalgout Nov 8, 2019
@luketlancaster luketlancaster force-pushed the fix/ch21350-action-created-event-dupe branch 2 times, most recently from 887ca58 to d7769d2 Nov 8, 2019
@luketlancaster luketlancaster force-pushed the fix/ch21350-action-created-event-dupe branch from d7769d2 to 230597c Nov 8, 2019
@paulfalgout paulfalgout merged commit 8e6a234 into master Nov 8, 2019
5 checks passed
5 checks passed
Automated Preview AWS pull request preview
Details
codecov/patch 100% of diff hit (target 98.26%)
Details
codecov/project Absolute coverage decreased by -0.86% but relative coverage increased by +1.73% compared to afc1fb6
Details
cypress: care ops 61 tests passed in 01:11
Details
test-deploy Workflow: test-deploy
Details
@paulfalgout paulfalgout deleted the fix/ch21350-action-created-event-dupe branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.