Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates mn toolkit and removes patched code from this codebase #73

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@luketlancaster
Copy link
Member

commented Aug 30, 2019

  • Add the Clubhouse Story ID: [ch20897]
@luketlancaster luketlancaster requested a review from paulfalgout Aug 30, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 30, 2019

Codecov Report

Merging #73 into develop will decrease coverage by 1.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #73      +/-   ##
===========================================
- Coverage    98.94%   97.58%   -1.36%     
===========================================
  Files           80       79       -1     
  Lines         1421     1408      -13     
===========================================
- Hits          1406     1374      -32     
- Misses          15       34      +19
Impacted Files Coverage Δ
src/js/base/app.js 100% <ø> (ø) ⬆️
src/js/utils/duration.js 6.66% <0%> (-93.34%) ⬇️
src/js/utils/formatting.js 87.8% <0%> (-12.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee6139...8d36ee8. Read the comment docs.

@cypress

This comment has been minimized.

Copy link

commented Aug 30, 2019



Test summary

46 0 0 0


Run details

Project RoundingWell Care Ops Frontend
Status Passed
Commit 8d36ee8
Started Sep 3, 2019 2:44 PM
Ended Sep 3, 2019 2:45 PM
Duration 01:01 💡
OS Linux Debian - 9.6
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

left a comment

I'd like to keep the base component file but it can export Toolkit's component directly. This allows us to add on things in the future that we may want in the library or to have app-specific overrides without having to update the imports app-wide

@luketlancaster luketlancaster force-pushed the chore/ch20897-update-toolkit branch from 265f693 to b1ca4d3 Sep 3, 2019
@luketlancaster luketlancaster requested a review from paulfalgout Sep 3, 2019
@luketlancaster luketlancaster force-pushed the chore/ch20897-update-toolkit branch from b1ca4d3 to 8d36ee8 Sep 3, 2019
@paulfalgout paulfalgout merged commit 7e7169f into develop Sep 3, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/project 97.58% (-1.36%) compared to cee6139
Details
Automated Preview AWS pull request preview
Details
codecov/patch Coverage not affected when comparing cee6139...8d36ee8
Details
cypress: care ops 46 tests passed in 00:52
Details
test-deploy Workflow: test-deploy
Details
@paulfalgout paulfalgout deleted the chore/ch20897-update-toolkit branch Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.