Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move auth to a separate chunk #74

Merged
merged 5 commits into from Sep 5, 2019

Conversation

@paulfalgout
Copy link
Member

commented Sep 5, 2019

  • Add the Clubhouse Story ID: [ch20925]
    This also improves the auth experience.
paulfalgout added 3 commits Sep 5, 2019
It was _kind of working_
This will allow for us to separate the auth from the rest of the app (and potentially reuse this chunk for form.io)
This was copy-pasta from RWell but never used
@@ -1,7 +1,7 @@
{
"extends": "eslint:recommended",
"parserOptions": {
"ecmaVersion": 6,
"ecmaVersion": 2020,

This comment has been minimized.

Copy link
@luketlancaster

luketlancaster Sep 5, 2019

Member

Nothing like bumping it up 2014 versions :trollface:

@codecov

This comment has been minimized.

Copy link

commented Sep 5, 2019

Codecov Report

Merging #74 into develop will decrease coverage by 1.33%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #74      +/-   ##
===========================================
- Coverage    98.93%   97.59%   -1.34%     
===========================================
  Files           79       79              
  Lines         1408     1416       +8     
===========================================
- Hits          1393     1382      -11     
- Misses          15       34      +19
Impacted Files Coverage Δ
src/js/services/auth.js 100% <ø> (ø)
src/js/base/setup.js 100% <ø> (ø) ⬆️
src/js/app.js 100% <100%> (ø)
src/js/utils/duration.js 6.66% <0%> (-93.34%) ⬇️
src/js/utils/formatting.js 87.8% <0%> (-12.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e7169f...9edb58e. Read the comment docs.

@cypress

This comment has been minimized.

Copy link

commented Sep 5, 2019



Test summary

46 0 0 0


Run details

Project RoundingWell Care Ops Frontend
Status Passed
Commit 9edb58e
Started Sep 5, 2019 5:47 PM
Ended Sep 5, 2019 5:48 PM
Duration 00:54 💡
OS Linux Debian - 9.6
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@paulfalgout paulfalgout force-pushed the feature/ch20925-separate-auth branch 2 times, most recently from 66791a6 to 94eae78 Sep 5, 2019
paulfalgout added 2 commits Sep 5, 2019
Also utilize auth0's tenant sessions for logging in without a login screen.
@paulfalgout paulfalgout force-pushed the feature/ch20925-separate-auth branch from 94eae78 to 9edb58e Sep 5, 2019
Copy link
Member

left a comment

nothing jumping out at me as crazy, so :shipit:

@paulfalgout paulfalgout merged commit d88e70b into develop Sep 5, 2019
5 checks passed
5 checks passed
Automated Preview AWS pull request preview
Details
codecov/patch 100% of diff hit (target 98.93%)
Details
codecov/project Absolute coverage decreased by -1.33% but relative coverage increased by +1.06% compared to 7e7169f
Details
cypress: care ops 46 tests passed in 00:44
Details
test-deploy Workflow: test-deploy
Details
@paulfalgout paulfalgout deleted the feature/ch20925-separate-auth branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.