Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store viewId on view app #78

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@luketlancaster
Copy link
Member

commented Sep 10, 2019

Makes it available if restarting the app, not just navigating to it

  • Add the Clubhouse Story ID: [ch20974]
@luketlancaster luketlancaster requested a review from paulfalgout Sep 10, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 10, 2019

Codecov Report

Merging #78 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   97.59%   97.52%   -0.07%     
==========================================
  Files          79       79              
  Lines        1416     1417       +1     
==========================================
  Hits         1382     1382              
- Misses         34       35       +1
Impacted Files Coverage Δ
src/js/apps/patients/view/view_app.js 100% <100%> (ø) ⬆️
src/js/base/entity-service.js 95.83% <0%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f37c1...76a1f31. Read the comment docs.

@cypress

This comment has been minimized.

Copy link

commented Sep 10, 2019



Test summary

46 0 0 0


Run details

Project RoundingWell Care Ops Frontend
Status Passed
Commit 76a1f31
Started Sep 11, 2019 1:30 AM
Ended Sep 11, 2019 1:30 AM
Duration 00:40 💡
OS Linux Debian - 9.6
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@luketlancaster luketlancaster requested a review from dhrrgn Sep 10, 2019
@luketlancaster luketlancaster changed the base branch from develop to master Sep 10, 2019
Copy link
Contributor

left a comment

This looks sane and correct to me.

Copy link
Member

left a comment

Can you remove the beforeStart viewId argument? Otherwise merge away.

Makes it available if restarting the app, not just navigating to it
@luketlancaster luketlancaster force-pushed the fix/ch20974-incorrect-filter-on-views branch from e36f864 to 76a1f31 Sep 11, 2019
@luketlancaster luketlancaster requested a review from paulfalgout Sep 11, 2019
@luketlancaster luketlancaster merged commit f3a0bb3 into master Sep 11, 2019
5 checks passed
5 checks passed
Automated Preview AWS pull request preview
Details
codecov/patch 100% of diff hit (target 97.59%)
Details
codecov/project Absolute coverage decreased by -0.06% but relative coverage increased by +2.4% compared to 05f37c1
Details
cypress: care ops 46 tests passed in 00:33
Details
test-deploy Workflow: test-deploy
Details
@luketlancaster luketlancaster deleted the fix/ch20974-incorrect-filter-on-views branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.