Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formio POC #84

Merged
merged 3 commits into from Sep 23, 2019

Conversation

@paulfalgout
Copy link
Member

commented Sep 18, 2019

  • Add the Clubhouse Story ID: [ch21006]
@paulfalgout paulfalgout requested a review from luketlancaster Sep 18, 2019
@cypress

This comment has been minimized.

Copy link

commented Sep 18, 2019



Test summary

46 0 0 0


Run details

Project RoundingWell Care Ops Frontend
Status Passed
Commit 2800b1b
Started Sep 18, 2019 1:49 PM
Ended Sep 18, 2019 1:49 PM
Duration 00:49 💡
OS Linux Debian - 9.6
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@paulfalgout

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2019

Something strange going on with istanbul and the handlebars update wycats/handlebars.js#1553 I'm going to revert that update shortly. I think the test are ok, but I need to test further.

@codecov

This comment has been minimized.

Copy link

commented Sep 18, 2019

Codecov Report

Merging #84 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #84   +/-   ##
========================================
  Coverage    97.62%   97.62%           
========================================
  Files           79       79           
  Lines         1434     1434           
========================================
  Hits          1400     1400           
  Misses          34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a56198...2800b1b. Read the comment docs.

@paulfalgout

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2019

Going to rebuild the commits, but here's the form example: https://fe-feature-ch21006-formio-poc.preview.roundingwell.com/forms/12345

paulfalgout added 3 commits Sep 18, 2019
Updating dependencies reduces our overall installs, but our libs won't share dependencies.
If a redirectPath isn't in localStorage it's possible for login to try and route to `authenticate/`.  This change ensures that the user is at least redirected somewhere valid.
@paulfalgout paulfalgout force-pushed the feature/ch21006-formio-poc branch from 4c7d2cb to 2800b1b Sep 18, 2019
@paulfalgout paulfalgout merged commit bad9bec into develop Sep 23, 2019
5 checks passed
5 checks passed
Automated Preview AWS pull request preview
Details
codecov/patch Coverage not affected when comparing 5a56198...2800b1b
Details
codecov/project 97.62% remains the same compared to 5a56198
Details
cypress: care ops 46 tests passed in 00:42
Details
test-deploy Workflow: test-deploy
Details
@paulfalgout paulfalgout deleted the feature/ch21006-formio-poc branch Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.