Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form routes #88

Merged
merged 4 commits into from Sep 26, 2019

Conversation

@paulfalgout
Copy link
Member

commented Sep 25, 2019

  • Add the Clubhouse Story ID: [ch21016]

Details on commit messages

paulfalgout added 3 commits Sep 25, 2019
Recently we were not able to update handlebars due to a bug in that lib which has been resolved.
`formapp` is unlikely to be a customer facing url where as `/forms` might.  It is also clearer that this is a separate app from `app`
There will almost certainly be a use case for clearing the latest list, but for now it seems like it'll be the exeption to the rule.
@paulfalgout paulfalgout requested a review from luketlancaster Sep 25, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 25, 2019

Codecov Report

Merging #88 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #88      +/-   ##
===========================================
+ Coverage    97.62%   97.63%   +<.01%     
===========================================
  Files           79       79              
  Lines         1434     1439       +5     
===========================================
+ Hits          1400     1405       +5     
  Misses          34       34
Impacted Files Coverage Δ
src/js/apps/patients/patients-main_app.js 100% <ø> (ø) ⬆️
src/js/base/routerapp.js 97.95% <100%> (ø) ⬆️
src/js/views/globals/root_views.js 93.89% <100%> (+0.04%) ⬆️
src/js/apps/globals/app-frame_app.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad9bec...5d698d0. Read the comment docs.

@cypress

This comment has been minimized.

Copy link

commented Sep 25, 2019



Test summary

47 0 0 0


Run details

Project RoundingWell Care Ops Frontend
Status Passed
Commit 5d698d0
Started Sep 25, 2019 4:35 PM
Ended Sep 25, 2019 4:36 PM
Duration 01:06 💡
OS Linux Debian - 9.6
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@paulfalgout

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2019

[🎉] Add tests for coverage

This hides and shows the nav
@paulfalgout paulfalgout force-pushed the feature/ch21016-add-form-routes branch from 482398a to 5d698d0 Sep 25, 2019
@paulfalgout paulfalgout merged commit 8f9952c into develop Sep 26, 2019
5 checks passed
5 checks passed
Automated Preview AWS pull request preview
Details
codecov/patch 100% of diff hit (target 97.62%)
Details
codecov/project 97.63% (+<.01%) compared to bad9bec
Details
cypress: care ops 47 tests passed in 00:59
Details
test-deploy Workflow: test-deploy
Details
@paulfalgout paulfalgout deleted the feature/ch21016-add-form-routes branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.