Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to auth0 access token #89

Merged
merged 3 commits into from Sep 30, 2019

Conversation

@paulfalgout
Copy link
Member

commented Sep 30, 2019

  • Add the Clubhouse Story ID: [ch21061]

Should be merged with RoundingWell/care-ops-backend#279

@codecov

This comment has been minimized.

Copy link

commented Sep 30, 2019

Codecov Report

Merging #89 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #89      +/-   ##
===========================================
- Coverage    97.63%   97.63%   -0.01%     
===========================================
  Files           79       79              
  Lines         1439     1436       -3     
===========================================
- Hits          1405     1402       -3     
  Misses          34       34
Impacted Files Coverage Δ
src/js/apps/globals/app-frame_app.js 100% <ø> (ø) ⬆️
src/js/apps/patients/list/patients-all_app.js 100% <100%> (ø) ⬆️
src/js/app.js 100% <100%> (ø) ⬆️
src/js/views/globals/app-nav/app-nav_views.js 100% <100%> (ø) ⬆️
src/js/apps/patients/patient/action/action_app.js 100% <100%> (ø) ⬆️
src/js/views/patients/actions/actions_views.js 100% <100%> (ø) ⬆️
src/js/services/bootstrap.js 100% <100%> (ø)
src/js/views/patients/view/view_views.js 100% <100%> (ø) ⬆️
src/js/apps/patients/view/view_app.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f9952c...d0e6117. Read the comment docs.

@cypress

This comment has been minimized.

Copy link

commented Sep 30, 2019



Test summary

47 0 0 0


Run details

Project RoundingWell Care Ops Frontend
Status Passed
Commit d0e6117
Started Sep 30, 2019 2:18 PM
Ended Sep 30, 2019 2:19 PM
Duration 00:48 💡
OS Linux Debian - 9.6
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Should be the best, most secure login we can get.
@paulfalgout paulfalgout force-pushed the feature/ch21061-access-token branch from b747dd3 to d0e6117 Sep 30, 2019
Copy link
Contributor

left a comment

🎉

@luketlancaster

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

@paulfalgout you want this to go into the release?

@luketlancaster luketlancaster merged commit b542116 into develop Sep 30, 2019
5 checks passed
5 checks passed
Automated Preview AWS pull request preview
Details
codecov/patch 100% of diff hit (target 97.63%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +2.36% compared to 8f9952c
Details
cypress: care ops 47 tests passed in 00:41
Details
test-deploy Workflow: test-deploy
Details
@luketlancaster luketlancaster deleted the feature/ch21061-access-token branch Sep 30, 2019
prompt,
});
}
let auth0;

This comment has been minimized.

Copy link
@shadowhand

shadowhand Sep 30, 2019

Contributor

Shouldn't this be in a separate import? Such as src/js/utils/auth.js ?

import createAuth0Client from '@auth0/auth0-spa-js'

const auth = await createAuth0Client({
  /* ??? */
});

export default auth;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.