Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use audience for auth0 #91

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@paulfalgout
Copy link
Member

commented Oct 9, 2019

Without setting the audience you get an opaque access token

Without setting the audience you get an opaque access token
@paulfalgout paulfalgout requested review from shadowhand and luketlancaster Oct 9, 2019
@codecov

This comment has been minimized.

Copy link

commented Oct 9, 2019

Codecov Report

Merging #91 into develop will decrease coverage by 1.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #91      +/-   ##
===========================================
- Coverage    98.95%   97.63%   -1.33%     
===========================================
  Files           79       79              
  Lines         1436     1436              
===========================================
- Hits          1421     1402      -19     
- Misses          15       34      +19
Impacted Files Coverage Δ
src/js/utils/duration.js 6.66% <0%> (-93.34%) ⬇️
src/js/utils/formatting.js 87.8% <0%> (-12.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b542116...0bae64e. Read the comment docs.

@cypress

This comment has been minimized.

Copy link

commented Oct 9, 2019



Test summary

47 0 0 0


Run details

Project RoundingWell Care Ops Frontend
Status Passed
Commit 0bae64e
Started Oct 9, 2019 5:30 PM
Ended Oct 9, 2019 5:31 PM
Duration 00:57 💡
OS Linux Debian - 9.6
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@paulfalgout

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

Ignore codecov here. It's a false report.

@paulfalgout paulfalgout merged commit 564f6c8 into develop Oct 9, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/project 97.63% (-1.33%) compared to b542116
Details
Automated Preview AWS pull request preview
Details
codecov/patch Coverage not affected when comparing b542116...0bae64e
Details
cypress: care ops 47 tests passed in 00:50
Details
test-deploy Workflow: test-deploy
Details
@paulfalgout paulfalgout deleted the use-auth0-audience branch Oct 9, 2019
Copy link
Contributor

left a comment

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.