Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

styling fixes & countdown voting clock #153

Merged
merged 28 commits into from May 13, 2018
Merged

Conversation

lazarovicedo
Copy link
Contributor

keep footer on the bottom, added loading bar (vertical centered) on token list, truncate urls on representatives list, display wallet version on the footer (from data stored on package.json), truncate token name on send page

…oken list, truncate urls on representatives list, display wallet version on the footer (from data stored on package.json), truncate token name on send page
Copy link
Contributor

@DevObs1 DevObs1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lazarovicedo,
The sitekey corresponds to the domain tronscan.org?
src/components/account/LoginWithCaptcha.js, line 108

@lazarovicedo
Copy link
Contributor Author

DevObs1, no. that sitekey is for localhost. Anyway, that captcha feature will be disabled by now as suggested by @Rovak

@DevObs1
Copy link
Contributor

DevObs1 commented May 5, 2018

Why should it be disabled?
Because I wanted to work on this fix too :) but I was thinking of contacting @Rovak Rovak before to generate a sitekey for PR

Hide token table header if the are tokens to list. Removed repeated alert message regarding testnet
@lazarovicedo lazarovicedo mentioned this pull request May 5, 2018
@lazarovicedo
Copy link
Contributor Author

@DevObs1 , Do you know any popular web wallet that implements a captcha?

@DevObs1
Copy link
Contributor

DevObs1 commented May 5, 2018

@lazarovicedo : I looked in a dozen sites but none offers reCaptcha (either for login or registration)

@lazarovicedo lazarovicedo changed the title styling fixes styling fixes & countdown voting clock May 7, 2018
* 'master' of https://github.com/lazarovicedo/wallet-web: (26 commits)
  fix issue Rovak#178
  Change password to private key
  change rendering condition
  apply pagination for accounts
  add PaginationBar component
  remove unused import
  change comparison operator
  add translate
  add translate
  remove duplicate key
  bump wallet-api
  bump wallet-api
  bump wallet-api
  bump wallet-api
  fix addresses
  resolve conflict
  Resolve conflict
  del lock
  Update ko.js
  Update ko.js
  ...

# Conflicts:
#	src/components/account/Account.js
Copy link
Owner

@Rovak Rovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error when registering a new account

screenshot from 2018-05-11 19-45-26

@Rovak
Copy link
Owner

Rovak commented May 11, 2018

After registering / logging in and refreshing i get this error

screenshot from 2018-05-11 19-46-17

key: undefined,
address: undefined,
isLoggedIn: false,
activeLanguage: (Lockr.get("language") !== undefined ? Lockr.get("language") : 'en'),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locker.get has a second parameter for a default value, this can be simplified to Lockr.get("language", "en")

isLoggedIn: false,
activeLanguage: (Lockr.get("language") !== undefined ? Lockr.get("language") : 'en'),
account: {
key: (Lockr.get("account_key") !== undefined ? Lockr.get("account_key") : undefined),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be simplified to Lockr.get("account_key")

account: {
key: (Lockr.get("account_key") !== undefined ? Lockr.get("account_key") : undefined),
address: (Lockr.get("account_key") !== undefined ? privateKeyToAddress(Lockr.get("account_key")) : undefined),
isLoggedIn: (Lockr.get("account_key") !== undefined ? true : false)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be simplified to Lockr.get("account_key") !== undefined

Copy link
Contributor Author

@lazarovicedo lazarovicedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplified to Lockr.get("account_key")

fix var reasignment
mediaquery not used on representatives.js cause now using responsive table
removed duplicated send_TRX word
… IS_TESTNET const for global testnet alert management
Updated info on voting intervals (6h) when applying for delegate
@Rovak
Copy link
Owner

Rovak commented May 13, 2018

very nice improvements, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants