styling fixes & countdown voting clock #153
Conversation
* 'master' of https://github.com/lazarovicedo/wallet-web: hide my transaction link
…oken list, truncate urls on representatives list, display wallet version on the footer (from data stored on package.json), truncate token name on send page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lazarovicedo,
The sitekey corresponds to the domain tronscan.org?
src/components/account/LoginWithCaptcha.js, line 108
DevObs1, no. that sitekey is for localhost. Anyway, that captcha feature will be disabled by now as suggested by @Rovak |
Why should it be disabled? |
Hide token table header if the are tokens to list. Removed repeated alert message regarding testnet
@DevObs1 , Do you know any popular web wallet that implements a captcha? |
@lazarovicedo : I looked in a dozen sites but none offers reCaptcha (either for login or registration) |
* 'master' of https://github.com/lazarovicedo/wallet-web: (26 commits) fix issue Rovak#178 Change password to private key change rendering condition apply pagination for accounts add PaginationBar component remove unused import change comparison operator add translate add translate remove duplicate key bump wallet-api bump wallet-api bump wallet-api bump wallet-api fix addresses resolve conflict Resolve conflict del lock Update ko.js Update ko.js ... # Conflicts: # src/components/account/Account.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/reducers/app.js
Outdated
key: undefined, | ||
address: undefined, | ||
isLoggedIn: false, | ||
activeLanguage: (Lockr.get("language") !== undefined ? Lockr.get("language") : 'en'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locker.get
has a second parameter for a default value, this can be simplified to Lockr.get("language", "en")
src/reducers/app.js
Outdated
isLoggedIn: false, | ||
activeLanguage: (Lockr.get("language") !== undefined ? Lockr.get("language") : 'en'), | ||
account: { | ||
key: (Lockr.get("account_key") !== undefined ? Lockr.get("account_key") : undefined), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be simplified to Lockr.get("account_key")
src/reducers/app.js
Outdated
account: { | ||
key: (Lockr.get("account_key") !== undefined ? Lockr.get("account_key") : undefined), | ||
address: (Lockr.get("account_key") !== undefined ? privateKeyToAddress(Lockr.get("account_key")) : undefined), | ||
isLoggedIn: (Lockr.get("account_key") !== undefined ? true : false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be simplified to Lockr.get("account_key") !== undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simplified to Lockr.get("account_key")
fix var reasignment mediaquery not used on representatives.js cause now using responsive table removed duplicated send_TRX word
… IS_TESTNET const for global testnet alert management
Updated info on voting intervals (6h) when applying for delegate
very nice improvements, thanks! |
keep footer on the bottom, added loading bar (vertical centered) on token list, truncate urls on representatives list, display wallet version on the footer (from data stored on package.json), truncate token name on send page