Roy van Kaathoven Rovak

Developer Program Member

Organizations

Socialog Cybermex Quadira Garlua Scalext
Rovak commented on issue Rovak/InlineAttachment#51
Roy van Kaathoven

@tamagokun thanks for the confirmation, i will make a fix soonish

Rovak commented on issue Rovak/InlineAttachment#52
Roy van Kaathoven

I've been doing some tests and implementing simple behavior is easy. I think the exceptions are gonna be harder to implement in the editor because …

Rovak commented on issue Rovak/InlineAttachment#52
Roy van Kaathoven

Good one, gonna look into it this weekend!

Rovak commented on issue Rovak/InlineAttachment#51
Roy van Kaathoven

Moving the code below the xhr.open solves the error for me: xhr.open('POST', settings.uploadUrl); // Add any available extra headers if (typeof set…

Rovak commented on pull request Rovak/InlineAttachment#44
Roy van Kaathoven

It doesn't feel right to do file handling in a hook that is meant to check if a file is allowed or not. I made a new issue #50 to think of an API t…

Roy van Kaathoven
Support Text Files
Roy van Kaathoven
Saving with attached file name
Rovak commented on issue Rovak/InlineAttachment#23
Roy van Kaathoven

Fixed in v2

Roy van Kaathoven
Add Bower Support
Roy van Kaathoven
CodeMirror 4
Roy van Kaathoven
Differentiate txt file and images
Rovak commented on issue Rovak/InlineAttachment#40
Roy van Kaathoven

Fix is merged in master

Rovak commented on pull request Rovak/InlineAttachment#44
Roy van Kaathoven

hmm, i guess it would make sense to add an extra hook which is called before any validations, something like beforeFileReceived

Rovak commented on pull request Rovak/InlineAttachment#44
Roy van Kaathoven

I think the best place would be onFileReceived var options = { onFileReceived: function(file) { if (file.type.match(/^text/) && !file.getAsString) { …

Rovak opened pull request Rovak/InlineAttachment#49
Roy van Kaathoven
Firefox Support
4 commits with 168 additions and 33 deletions
Rovak closed pull request Rovak/InlineAttachment#41
Roy van Kaathoven
2.0.0 Firefox Support
Rovak deleted branch 2.0.0 at Rovak/InlineAttachment
Roy van Kaathoven
Rovak deleted branch 2.0.0-bower at Rovak/InlineAttachment