Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Notifications (for linux too!) #1
A thing it could be ok to work on should be installing only the right dependency (TerminalNotifier on mac, libnotify on linux, libwhatever on windows) and include it in lib/miyuki.rb, instead of downloading 3 or more libraries and use just one of those.
This PR also fixes a bug in the comparison of torrents (to check if there are new torrents), but in the wrong way. The best way is to address this problem in Yamazaki::Torrent and override "==" operator. I would have been more than happy to provide it myself with a PR on Yamazaki, but I wasn't able to test it.
First of all, thanks for your PR. Secondly, check the indentation of your editor, because it sucks, and have a deep look at ruby coding guidelines.
Anyway, I removed for now the sound parameter and the support to older configurations. At the first one we'll work later, while the latter no one cares about the old configuration.
Thanks again for your contribuitions on this project. I hope to see soon your face here (but remember that Miyuki is only mine :D)