Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track file not updated #7

Merged
merged 9 commits into from May 23, 2015
Merged

Track file not updated #7

merged 9 commits into from May 23, 2015

Conversation

winterthediplomat
Copy link
Contributor

Fixes alfateam123/Miyuki#2
The :git parameter in the gemfile for hydride0/yamazaki is needed to test Miyuki on Travis with the needed patches to make it work. It will be removed when @hydride0 will merge hydride0/yamazaki#11

I'm testing on a debian server. I didn't install libnotify, as
it requires gnome (`dnw`).

Tests have to notify things, and the lack of libnotify
raises exceptions that break automated tests on my platform
(when executed with `rake test`).
@RoxasShadow
Copy link
Owner

Thanks mate. I'll wait for hydride0/yamazaki#11 be merged so we can rid off those references.

@@ -13,5 +13,5 @@
##

module Miyuki
VERSION = '0.5.8.1'
VERSION = '0.5.8.2'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok, but usually is good practice leaving to the manteiner the bump of the version 💃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh :///:

the `Notifier#notify` call was wrapped in a `begin ... rescue`
block in order to fix tests.

In case you launch tests on a platform where `libnotify` is not
installed, you can apply the patch added with this commit.
Refer to the new `TROUBLESHOOTING.md` file to find fixes
in case you get errors.
@RoxasShadow
Copy link
Owner

👍

RoxasShadow added a commit that referenced this pull request May 23, 2015
@RoxasShadow RoxasShadow merged commit 6b2e80e into RoxasShadow:master May 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants