Track file not updated #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm testing on a debian server. I didn't install libnotify, as it requires gnome (`dnw`). Tests have to notify things, and the lack of libnotify raises exceptions that break automated tests on my platform (when executed with `rake test`).
Owner
|
Thanks mate. I'll wait for hydride0/yamazaki#11 be merged so we can rid off those references. |
lib/miyuki/version.rb
Outdated
Owner
There was a problem hiding this comment.
This is ok, but usually is good practice leaving to the manteiner the bump of the version 💃
the `Notifier#notify` call was wrapped in a `begin ... rescue` block in order to fix tests. In case you launch tests on a platform where `libnotify` is not installed, you can apply the patch added with this commit. Refer to the new `TROUBLESHOOTING.md` file to find fixes in case you get errors.
Owner
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes alfateam123/Miyuki#2
The
:gitparameter in the gemfile for hydride0/yamazaki is needed to test Miyuki on Travis with the needed patches to make it work. It will be removed when @hydride0 will merge hydride0/yamazaki#11