New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync test message and behaviour in feature.t #9

Merged
merged 1 commit into from Oct 13, 2016

Conversation

Projects
None yet
2 participants
@kaoru
Contributor

kaoru commented Aug 31, 2015

Did say "v5.8" but check for less than or equal to 5.10. Now the message
matches the behaviour.


This is my rather rushed attempt at a pull request for my August CPAN Pull Request Challenge :-) Sorry I wasn't able to do something more substantial.

Part of the reason I didn't do anything better was because I had a lot of trouble getting your Dist::Zilla plugins to play nicely and eventually had to give up... currently I'm getting a warning and an error:

Pod::Elemental warning

not handling plain * items yet at /home/alex/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Pod/Elemental/Transformer/List/Converter.pm line 57.

@Filter/Manifest error

Could not decode MANIFEST; bytes from coderef added by @Filter/Manifest (Dist::Zilla::Plugin::Manifest line 55); error was: Can't decode text from 'bytes' encoding; maybe you need the [Encoding] plugin to specify an encoding at /home/alex/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Dist/Zilla/Role/File.pm line 153.
Sync test message and behaviour in feature.t
Did say "v5.8" but check for less than or equal to 5.10. Now the message
matches the behaviour.
@rsrchboy

This comment has been minimized.

Show comment
Hide comment
@rsrchboy

rsrchboy Oct 13, 2016

Owner

Thanks! ...and you're right about my dzil configuration; I really ought to go back through it and take out those things that make it difficult for others to use... Awkward in situations like this.

Owner

rsrchboy commented Oct 13, 2016

Thanks! ...and you're right about my dzil configuration; I really ought to go back through it and take out those things that make it difficult for others to use... Awkward in situations like this.

@rsrchboy rsrchboy merged commit 8d000d1 into rsrchboy:master Oct 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment