Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of mean_squared_log_error #23

Closed
wants to merge 1 commit into from

Conversation

akondas
Copy link

@akondas akondas commented May 14, 2019

Instead of focusing on who copies the code from whom and how well the license is understood (https://github.com/php-ai/php-ml/issues/379), let's focus on providing the correct value.

Here is an example from sklearn package:
Screenshot from 2019-05-14 08-14-24

Copy link
Member

@andrewdalpino andrewdalpino left a comment

Thanks for the PR, I left one comment regarding optimizing the SLE computation

Other than that, it looks good

src/CrossValidation/Reports/ResidualAnalysis.php Outdated Show resolved Hide resolved
@akondas
Copy link
Author

@akondas akondas commented May 15, 2019

Lol, thanks anyway. A very nice example for others 👏

@andrewdalpino
Copy link
Member

@andrewdalpino andrewdalpino commented May 16, 2019

Your PR was denied because you violated this community's anti plagiarism policy by trying to claim code that I wrote as your own. I'll refer to the issue I posted (which you continually have tried to cover up) here

Quoting our plagiarism policy ...

Our community has a strong stance against plagiarism, or the copying of another author's code without attribution. Since the spirit of open source is to make code freely available, it is up to the community to enforce policies that deter plagiarism. As such, we do not allow contributions from those who violate this policy.

https://github.com/RubixML/RubixML/blob/master/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants