Fixed validation failing when there was a whitespace between the currency symbol and amount in a String price. #167

Merged
merged 1 commit into from Apr 21, 2014

Conversation

Projects
None yet
2 participants
@mrbongiolo
Contributor

mrbongiolo commented Feb 11, 2014

The current validator was failing when we tried to use values like those:

product.price = "$ 123,456.89"
product.price = "R$ 123.456,78"

The problem was that abs_raw_value wasn't striping whitespaces after removing the currency symbol.

PS. That's like my first time sending a pull request, so I'm not sure if I did everything right.

semmons99 added a commit that referenced this pull request Apr 21, 2014

Merge pull request #167 from mrbongiolo/master
Fixed validation failing when there was a whitespace between the currency symbol and amount in a String price.

@semmons99 semmons99 merged commit 0bbe540 into RubyMoney:master Apr 21, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment