database schema respects the default currency #75

Merged
merged 1 commit into from Feb 15, 2013

Conversation

Projects
None yet
2 participants
@deepak
Contributor

deepak commented Jan 31, 2013

when default currency is changed. the amount column in the database
has a postfix of the subunit of the currency so set

likewise for the currency column as well. It also changes the
default value to the currencies iso code

add gem debugger for ruby 1.9 and ruby-debug for ruby 1.8

spec/configuration_spec.rb
@@ -17,7 +17,7 @@
Money.ca_dollar(100).exchange_to("USD").should == Money.new(80, "USD")
end
- it "sets no_cents_if_whole value for formatted output globally" do
+ it "sets no_cents_if_whole value for formatted output globally", failing: true do

This comment has been minimized.

Show comment Hide comment
@alup

alup Feb 6, 2013

Member

failing: true should be removed

@alup

alup Feb 6, 2013

Member

failing: true should be removed

This comment has been minimized.

Show comment Hide comment
@deepak

deepak Feb 8, 2013

Contributor

fixed. squashed on top of old commit

@deepak

deepak Feb 8, 2013

Contributor

fixed. squashed on top of old commit

@@ -11,3 +11,14 @@ end
platforms :ruby do
gem "sqlite3"
end
+
+platform :mri do

This comment has been minimized.

Show comment Hide comment
@alup

alup Feb 6, 2013

Member

All this block should be removed.

@alup

alup Feb 6, 2013

Member

All this block should be removed.

This comment has been minimized.

Show comment Hide comment
@deepak

deepak Feb 8, 2013

Contributor

debugger gem supports MRI versions after 1.9.2-p290
https://github.com/cldwalker/debugger-ruby_core_source/tree/master/lib/debugger/ruby_core_source

we can add https://github.com/jruby/jruby-debug for JRuby.
I did not add it as i am not using JRuby now

@deepak

deepak Feb 8, 2013

Contributor

debugger gem supports MRI versions after 1.9.2-p290
https://github.com/cldwalker/debugger-ruby_core_source/tree/master/lib/debugger/ruby_core_source

we can add https://github.com/jruby/jruby-debug for JRuby.
I did not add it as i am not using JRuby now

This comment has been minimized.

Show comment Hide comment
@alup

alup Feb 8, 2013

Member

I don't want to add it right now as it is not related to the pull request.
Secondly, money-rails supports only ruby versions > 1.9.2 since September (I think).

@alup

alup Feb 8, 2013

Member

I don't want to add it right now as it is not related to the pull request.
Secondly, money-rails supports only ruby versions > 1.9.2 since September (I think).

This comment has been minimized.

Show comment Hide comment
@deepak

deepak Feb 15, 2013

Contributor

ok. removed the gem for ruby 1.8

@deepak

deepak Feb 15, 2013

Contributor

ok. removed the gem for ruby 1.8

@alup

This comment has been minimized.

Show comment Hide comment
@alup

alup Feb 13, 2013

Member

I will gladly merge this if you fix the failing specs :)

Member

alup commented Feb 13, 2013

I will gladly merge this if you fix the failing specs :)

database schema respects the default currency
when default currency is changed. the amount column in the database
has a postfix of the subunit of the currency so set

likewise for the currency column as well. It also changes the
default value to the currencies iso code

add gem debugger for ruby 1.9 on MRI ruby

fix two failing tests where the default_currency is set to EUR
in spec/dummy/config/initializers/money.rb
@alup

This comment has been minimized.

Show comment Hide comment
@alup

alup Feb 15, 2013

Member

super!!! thnx for your contribution :)

Member

alup commented Feb 15, 2013

super!!! thnx for your contribution :)

@deepak

This comment has been minimized.

Show comment Hide comment
@deepak

deepak Feb 15, 2013

Contributor

@alup fixed failing tests.
PS: default_currency is set to EUR in spec/dummy/config/initializers/money.rb

Contributor

deepak commented Feb 15, 2013

@alup fixed failing tests.
PS: default_currency is set to EUR in spec/dummy/config/initializers/money.rb

@alup alup closed this Feb 15, 2013

@alup alup reopened this Feb 15, 2013

alup added a commit that referenced this pull request Feb 15, 2013

Merge pull request #75 from deepak/feature/support-inr-paise
database schema respects the default currency

@alup alup merged commit 87ffa51 into RubyMoney:master Feb 15, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment