Permalink
Browse files

update deps

  • Loading branch information...
1 parent 89a4fc4 commit 4facf60cc1dc7c2b686e67f7536e8fa5a138d8d5 @semmons99 semmons99 committed Jun 5, 2012
Showing with 24 additions and 15 deletions.
  1. +20 −11 Gemfile.lock
  2. +4 −4 money.gemspec
View
@@ -3,24 +3,33 @@ PATH
specs:
money (5.0.0)
i18n (~> 0.6.0)
- multi_json (~> 1.3.5)
+ multi_json (~> 1.3.6)
GEM
remote: http://rubygems.org/
specs:
diff-lcs (1.1.3)
ffi (1.0.11)
- guard (1.0.3)
- ffi (>= 0.5.0)
+ guard (1.1.1)
+ listen (>= 0.4.2)
thor (>= 0.14.6)
- guard-rspec (0.7.2)
- guard (>= 0.10.0)
- guard-spork (0.8.0)
- guard (>= 0.10.0)
+ guard-rspec (1.0.0)
+ guard (>= 1.1)
+ guard-spork (1.0.0)
+ guard (>= 1.0.0)
spork (>= 0.8.4)
i18n (0.6.0)
- multi_json (1.3.5)
+ listen (0.4.2)
+ rb-fchange (~> 0.0.5)
+ rb-fsevent (~> 0.9.1)
+ rb-inotify (~> 0.8.8)
+ multi_json (1.3.6)
rake (0.9.2.2)
+ rb-fchange (0.0.5)
+ ffi
+ rb-fsevent (0.9.1)
+ rb-inotify (0.8.8)
+ ffi (>= 0.5.0)
redcarpet (2.1.1)
rspec (2.10.0)
rspec-core (~> 2.10.0)
@@ -38,9 +47,9 @@ PLATFORMS
ruby
DEPENDENCIES
- guard (~> 1.0.2)
- guard-rspec (~> 0.7.2)
- guard-spork (~> 0.8.0)
+ guard (~> 1.1.1)
+ guard-rspec (~> 1.0.0)
+ guard-spork (~> 1.0.0)
money!
rake
redcarpet (~> 2.1.1)
View
@@ -13,15 +13,15 @@ Gem::Specification.new do |s|
s.required_rubygems_version = ">= 1.3.6"
s.add_dependency "i18n", "~> 0.6.0"
- s.add_dependency "multi_json", "~> 1.3.5"
+ s.add_dependency "multi_json", "~> 1.3.6"
s.add_development_dependency "rspec", "~> 2.10.0"
s.add_development_dependency "yard", "~> 0.8.1"
s.add_development_dependency "redcarpet", "~> 2.1.1"
- s.add_development_dependency "guard", "~> 1.0.2"
+ s.add_development_dependency "guard", "~> 1.1.1"
s.add_development_dependency "spork", "~> 0.9.0"
- s.add_development_dependency "guard-spork", "~> 0.8.0"
- s.add_development_dependency "guard-rspec", "~> 0.7.2"
+ s.add_development_dependency "guard-spork", "~> 1.0.0"
+ s.add_development_dependency "guard-rspec", "~> 1.0.0"
s.files = Dir.glob("{config,lib,spec}/**/*")
s.files += %w(CHANGELOG.md LICENSE README.md)

8 comments on commit 4facf60

gtd replied Jul 17, 2012

Is there a reason for the multi_json version bump here? Specs pass fine with 1.3.2 and keeping the most permissive dependencies is very helpful on libraries since applications can use a lot of them.

Owner

semmons99 replied Jul 18, 2012

we try to keep our dependencies up to date, that being said, it's high time we remove that dependency and just use the builtin json library

gtd replied Jul 18, 2012

That's good for testing but bad for downstream users (app developers) who might end up with dependency conflicts even if there is no actual logical conflict. I would argue that it's best for gems to have the most lenient requirements possible (~> 1.3.2 or even ~> 1.3 if you think it is more likely than not that 1.4 will work out of the box). Supporting the latest version is not the same as requiring it.

Owner

semmons99 replied Jul 18, 2012

I agree, and if you take a peek at #204 you'll see we're removing the need for multi_json

gtd replied Jul 19, 2012

Nice! That's definitely an improvement. One more suggestion: remove and ignore the Gemfile.lock. That way, every new developer who checks out the code will test the latest dependencies, and you also have better coverage of regressions by existing developers who have verifying Gemfile.locks.

Owner

semmons99 replied Jul 19, 2012

I'm actually not sure when the Gemfile.lock started getting tracked. It used to be in .gitignore

gtd replied Jul 19, 2012

Looks like at 3a6316b, and the author cites http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ which is bit ironic given that it gives exactly the opposite advice.

Owner

weppos replied Jul 23, 2012

My fault, you can revert 3a6316b

Please sign in to comment.