I would deprecate the following legacy behaviors, with target Money 3.3.
format(option1, option2, ...)
format(:option1 => ..., :option2 => ...)
Money.new(:currency => "EUR")
That would be great. I really like to get to a point by 3.5.0 where we don't have those types of hacks around anymore.
Deprecated Money#format with separate params instead of Hash.
Deprecated Money#new(0, :currency => "EUR") in favor of Money#new(0, "EUR").
Money#new(0, :currency => "EUR")
Deprecation target set to Money 3.5.0. (closed by 31214fe)
In d579d11 I also removed all the deprecations with target v3.2.0. I made it in a branch then merged the branch so we can easily revert the merge if we don't agree with it.
Lets back those changes out and leave them in a v3.2.0 branch for now. I'd like to release at least one more 3.1.* version before 3.2.0 to give everyone a little more time to remove their deprecated code.
Just to know, are you going to include the BigDecimal, #dollars and core extension changes in a 3.1.x release?
IMHO, they all deserve a minor bump ;)
By the way, I reverted the commit. I'm going to push the changes tomorrow.
For future reference, here's a tutorial to revert the revert of a merge.
Required to re-include the branch in to master when we are ready to merge the changes.
I'm thinking a 3.1.5 bump for BigDecimal and #dollars
Pushed the revert commit. Do you want to package a release now or are you waiting for #32?
Deprecated `Money#format` with separate params instead of Hash.
Deprecated `Money#new(0, :currency => "EUR")` in favor of `Money#new(0, "EUR")`.
Deprecation target set to Money 3.5.0. (closes #31)
Removed v3.2.0 deprecations (references #31)