Fix specs not making any assertions #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make two pull requests. I won't merge the attr_accessor change without more info. I only use private attr_accessor, no instance variables. |
|
@semmons99 no problem, that warning about private attributes is new to me as well. Edit: I found https://bugs.ruby-lang.org/issues/10967 talking about removing this "private attribute" warning. Personally I use this all the time so would be nice to know it doesn't generate warnings. |
|
@createdbypete just need to update the CHANGELOG.md file with what this change does. |
- Warning: possibly useless use of == in void context - FOO currency needed to be modified to match expected decimal places
- ambiguous first argument - unused variable
|
Updated the change log. |
semmons99
added a commit
that referenced
this pull request
Aug 27, 2015
Fix specs not making any assertions
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the gem I noticed a few Ruby warnings that could be easily fixed and also a couple of specs executing comparisons but not making any assertions.
These were found by running:
Side note: Today I learned Ruby does not like
privateattr_reader, the alternative is to raise visibility toprotectedor just use the instance variables. https://bugs.ruby-lang.org/issues/10967