Skip to content
Commits on May 16, 2016
  1. @rlaager @behlendorf

    zfs.8: Relative paths must start with ./

    Simply containing a slash is not enough, presumably because foo/bar
    could be either a dataset or a mountpoint.
    
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    Closes #4655
    rlaager committed with behlendorf May 16, 2016
  2. @behlendorf

    Merge branch 'man-page-fixes'

    A collection of corrections and various improvements to the man pages.
    
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Closes #4631
    Closes #4651
    behlendorf committed May 16, 2016
  3. @ahrens @behlendorf

    Illumos 1644 add ZFS "clones" property

    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: George Wilson <gwilson@zfsmail.com>
    Approved by: Gordon Ross <gwr@nexenta.com>
    
    References:
     https://www.illumos.org/issues/1644
    
    Ported-by: Richard Laager <rlaager@wiktel.com>
    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    ahrens committed with behlendorf May 11, 2016
  4. @rlaager @behlendorf

    Illumos 1502 Remove conversion cruft from manpages

    Reviewed by: Alexander Eremin <alexander.eremin@nexenta.com>
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Reviewed by: Garrett D'Amore <garrett.damore@gmail.com>
    
    References:
     https://www.illumos.org/issues/1502
    
    Ported-by: Richard Laager <rlaager@wiktel.com>
    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    
    Conflicts:
    	man/man8/zpool.8
    rlaager committed with behlendorf May 11, 2016
  5. @rubenk @behlendorf

    zfs.8 & mount.zfs.8: fix a few typos

    filesytem -> filesystem
    defntext -> defcontext
    
    Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
    rubenk committed with behlendorf May 16, 2016
  6. @rlaager @behlendorf

    zfs.8 & zpool.8: Standardize property value order

    The default value is now always listed first.
    
    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    rlaager committed with behlendorf May 11, 2016
  7. @rlaager @behlendorf

    zfs.8 & zpool.8: Various documentation edits

    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    rlaager committed with behlendorf May 11, 2016
  8. @rlaager @behlendorf

    zfs.8: Improve zfs upgrade documentation

    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    rlaager committed with behlendorf May 11, 2016
  9. @rlaager @behlendorf

    zfs.8: Cleanup stray code

    Bad copy-and-paste?
    
    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    rlaager committed with behlendorf May 11, 2016
  10. @rlaager @behlendorf

    zfs.8 & zpool.8: Drop legal/illegal

    There's a convention in documentation that these words not be used to
    mean "invalid".
    
    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    rlaager committed with behlendorf May 11, 2016
  11. @rlaager @behlendorf

    zfs.8: Fix minor typos and the like

    This commit only contains the most trivial of changes.
    
    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    rlaager committed with behlendorf May 11, 2016
  12. @rlaager @behlendorf

    zfs.8: Rework native vs user properties

    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    rlaager committed with behlendorf May 11, 2016
  13. @rlaager @behlendorf

    zfs.8 & zpool.8: Linux/Solaris differences

    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    rlaager committed with behlendorf May 11, 2016
  14. @rlaager @behlendorf

    zfs.8: Improve mount option documentation

    This change is primarily about adding inline references in the
    properties section to the traditional mount option names.
    
    There are some other editorial changes too.
    
    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    rlaager committed with behlendorf May 11, 2016
  15. @rlaager @behlendorf

    zfs.8: Improve consistency in size documentation

    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    rlaager committed with behlendorf May 11, 2016
  16. @rlaager @behlendorf

    zfs.8: Drop references to Oracle documentation

    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    rlaager committed with behlendorf May 11, 2016
  17. @rlaager @behlendorf

    zfs.8: zfs get and zfs list accept mountpoints

    Signed-off-by: Richard Laager <rlaager@wiktel.com>
    rlaager committed with behlendorf May 11, 2016
Commits on May 15, 2016
  1. @rtvd @behlendorf

    OpenZFS 6739 - assumption in cv_timedwait_hires

    Userland version of cv_timedwait_hires() always assumes absolute time.
    
    Reviewed by: Paul Dagnelie <pcd@delphix.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Robert Mustacchi <rm@joyent.com>
    Ported by: Denys Rtveliashvili <denys@rtveliashvili.name>
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    
    OpenZFS-issue: https://www.illumos.org/issues/6739
    OpenZFS-commit: illumos/illumos-gate@41c6413
    
    Porting Notes:
    The ported change has revealed a number of problems in the Linux-specific code,
    as it was expecting incorrect return codes from pthread_* functions.
    Reviewed and improved the usage of pthread_* function in lib/libzpool/kernel.c.
    rtvd committed with behlendorf May 15, 2016
Commits on May 14, 2016
  1. @jyxent @behlendorf

    Fix the test to use the variable

    Signed-off-by: Manuel Amador (Rudd-O) <rudd-o@rudd-o.com>
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Closes #4645
    jyxent committed with behlendorf May 13, 2016
Commits on May 13, 2016
Commits on May 12, 2016
  1. @tuxoko @behlendorf

    Use cv_timedwait_sig_hires in arc_reclaim_thread

    The was originally using interruptible cv_timedwait_sig, but was changed
    to uninterruptible cv_timedwait_hires in ae6d0c6. Use _sig_hires instead
    to allow interruptible sleep.
    
    Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Closes #4633
    Closes #4634
    tuxoko committed with behlendorf May 11, 2016
  2. @behlendorf

    A collection of dracut fixes

    - In older systems without sysroot.mount, import before dracut-mount,
      and re-enable old dracut mount hook
    - rootflags MUST be present even if the administrator neglected to
      specify it explicitly
    - Check that mount.zfs exists in sbindir
    - Remove awk and head as (now unused) requirements, add grep, and
      install the right mount.zfs
    - Eliminate one use of grep in Dracut
    - Use a more accurate grepping statement to identify zfsutil in rootflags
    - Ensure that pooldev is nonempty
    - Properly handle /dev/sd* devices and more
    - Use new -P to get list of zpool devices
    - Bail out of the generator when zfs:AUTO is on the root command line
    - Ignore errors from systemctl trying to load sysroot.mount, we only
      care about the output
    - Determine which one is the correct initqueuedir at run time.
    - Add a compatibility getargbool for our detection / setup script.
    - Update dracut .gitignore files
    
    Signed-off-by: <Matthew Thode mthode@mthode.org>
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Closes #4558
    Closes #4562
    committed with behlendorf Apr 24, 2016
  3. @danmcd @behlendorf

    OpenZFS 6093 - zfsctl_shares_lookup

    6093 zfsctl_shares_lookup should only VN_RELE() on zfs_zget() success
    
    Reviewed by: Gordon Ross <gwr@nexenta.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>
    Ported-by: Brian Behlendorf <behlendorf1@llnl.gov>
    
    OpenZFS-issue: https://www.illumos.org/issues/6093
    OpenZFS-commit: openzfs/openzfs@0f92170
    Closes #4630
    
    This function was always implemented slightly differently under Linux
    and therefore never suffered from this issue.  The patch has been
    updated and applied as cleanup in order to minimize differences with
    the upstream OpenZFS code.
    danmcd committed with behlendorf May 11, 2016
  4. @behlendorf

    Revert "Kill znode->z_gen field"

    This reverts commit 4cd7788.  The
    i_generation field in the inode is 32-bit and the SA code expects
    64-bit fixed values.  Revert this optimization for now until
    this is cleanly addressed.
    
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Issue #4538
    behlendorf committed May 12, 2016
  5. @tonyhutter @behlendorf

    Add -lhHpw options to "zpool iostat" for avg latency, histograms, & q…

    …ueues
    
    Update the zfs module to collect statistics on average latencies, queue sizes,
    and keep an internal histogram of all IO latencies.  Along with this, update
    "zpool iostat" with some new options to print out the stats:
    
    -l: Include average IO latencies stats:
    
     total_wait     disk_wait    syncq_wait    asyncq_wait  scrub
     read  write   read  write   read  write   read  write   wait
    -----  -----  -----  -----  -----  -----  -----  -----  -----
        -   41ms      -    2ms      -   46ms      -    4ms      -
        -    5ms      -    1ms      -    1us      -    4ms      -
        -    5ms      -    1ms      -    1us      -    4ms      -
        -      -      -      -      -      -      -      -      -
        -   49ms      -    2ms      -   47ms      -      -      -
        -      -      -      -      -      -      -      -      -
        -    2ms      -    1ms      -      -      -    1ms      -
    -----  -----  -----  -----  -----  -----  -----  -----  -----
      1ms    1ms    1ms  413us   16us   25us      -    5ms      -
      1ms    1ms    1ms  413us   16us   25us      -    5ms      -
      2ms    1ms    2ms  412us   26us   25us      -    5ms      -
        -    1ms      -  413us      -   25us      -    5ms      -
        -    1ms      -  460us      -   29us      -    5ms      -
    196us    1ms  196us  370us    7us   23us      -    5ms      -
    -----  -----  -----  -----  -----  -----  -----  -----  -----
    
    -w: Print out latency histograms:
    
    sdb           total           disk         sync_queue      async_queue
    latency    read   write    read   write    read   write    read   write   scrub
    -------  ------  ------  ------  ------  ------  ------  ------  ------  ------
    1ns           0       0       0       0       0       0       0       0       0
    ...
    33us          0       0       0       0       0       0       0       0       0
    66us          0       0     107    2486       2     788      12      12       0
    131us         2     797     359    4499      10     558     184     184       6
    262us        22     801     264    1563      10     286     287     287      24
    524us        87     575      71   52086      15    1063     136     136      92
    1ms         152    1190       5   41292       4    1693     252     252     141
    2ms         245    2018       0   50007       0    2322     371     371     220
    4ms         189    7455      22  162957       0    3912    6726    6726     199
    8ms         108    9461       0  102320       0    5775    2526    2526      86
    17ms         23   11287       0   37142       0    8043    1813    1813      19
    34ms          0   14725       0   24015       0   11732    3071    3071       0
    67ms          0   23597       0    7914       0   18113    5025    5025       0
    134ms         0   33798       0     254       0   25755    7326    7326       0
    268ms         0   51780       0      12       0   41593   10002   10002       0
    537ms         0   77808       0       0       0   64255   13120   13120       0
    1s            0  105281       0       0       0   83805   20841   20841       0
    2s            0   88248       0       0       0   73772   14006   14006       0
    4s            0   47266       0       0       0   29783   17176   17176       0
    9s            0   10460       0       0       0    4130    6295    6295       0
    17s           0       0       0       0       0       0       0       0       0
    34s           0       0       0       0       0       0       0       0       0
    69s           0       0       0       0       0       0       0       0       0
    137s          0       0       0       0       0       0       0       0       0
    -------------------------------------------------------------------------------
    
    -h: Help
    
    -H: Scripted mode. Do not display headers, and separate fields by a single
        tab instead of arbitrary space.
    
    -q: Include current number of entries in sync & async read/write queues,
        and scrub queue:
    
     syncq_read    syncq_write   asyncq_read  asyncq_write   scrubq_read
     pend  activ   pend  activ   pend  activ   pend  activ   pend  activ
    -----  -----  -----  -----  -----  -----  -----  -----  -----  -----
        0      0      0      0     78     29      0      0      0      0
        0      0      0      0     78     29      0      0      0      0
        0      0      0      0      0      0      0      0      0      0
        -      -      -      -      -      -      -      -      -      -
        0      0      0      0      0      0      0      0      0      0
        -      -      -      -      -      -      -      -      -      -
        0      0      0      0      0      0      0      0      0      0
    -----  -----  -----  -----  -----  -----  -----  -----  -----  -----
        0      0    227    394      0     19      0      0      0      0
        0      0    227    394      0     19      0      0      0      0
        0      0    108     98      0     19      0      0      0      0
        0      0     19     98      0      0      0      0      0      0
        0      0     78     98      0      0      0      0      0      0
        0      0     19     88      0      0      0      0      0      0
    -----  -----  -----  -----  -----  -----  -----  -----  -----  -----
    
    -p: Display numbers in parseable (exact) values.
    
    Also, update iostat syntax to allow the user to specify specific vdevs
    to show statistics for.  The three options for choosing pools/vdevs are:
    
    Display a list of pools:
        zpool iostat ... [pool ...]
    
    Display a list of vdevs from a specific pool:
        zpool iostat ... [pool vdev ...]
    
    Display a list of vdevs from any pools:
        zpool iostat ... [vdev ...]
    
    Lastly, allow zpool command "interval" value to be floating point:
        zpool iostat -v 0.5
    
    Signed-off-by: Tony Hutter <hutter2@llnl.gov
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Closes #4433
    tonyhutter committed with behlendorf Feb 29, 2016
  6. @marcelhuberfoo @behlendorf

    Fixes bug in fix_paths()

    Fixes bug introduced in commit 7d90f569a.  Hinted by gcc:
    
    libzfs_import.c: In function ‘fix_paths’:
    libzfs_import.c:602:28: warning: self-comparison always evaluates to true [-Wtautological-compare]
        if (best->ne_num_labels == best->ne_num_labels &&
    
    Signed-off-by: Marcel Huber <marcelhuberfoo@gmail.com>
    Signed-off-by: Chunwei Chen <tuxoko@gmail.com>
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Issue #4632
    marcelhuberfoo committed with behlendorf May 11, 2016
Commits on May 11, 2016
  1. @behlendorf

    Reduce stack usage of dmu_recv_stream function

    The receive_writer_arg and receive_arg structures become large
    when ZFS is compiled with debugging enabled. This results in
    gcc throwing an error about excessive stack usage:
    
      module/zfs/dmu_send.c: In function ‘dmu_recv_stream’:
      module/zfs/dmu_send.c:2502:1: error: the frame size of 1256 bytes is
      larger than 1024 bytes [-Werror=frame-larger-than=]
    
    Fix this by allocating those functions on the heap, rather than
    on the stack.
    
    With patch:    dmu_send.c:2350:1:dmu_recv_stream 240 static
    Without patch: dmu_send.c:2350:1:dmu_recv_stream 1336 static
    
    Signed-off-by: Nikolay Borisov <n.borisov.lkml@gmail.com>
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Closes #4620
    Nikolay Borisov committed with behlendorf May 9, 2016
  2. @xen0l @behlendorf

    OpenZFS 3993, 4700

    3993 zpool(1M) and zfs(1M) should support -p for "list" and "get"
    4700 "zpool get" doesn't support -H or -o options
    
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>
    Ported by: Tony Hutter <hutter2@llnl.gov>
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    
    OpenZFS-issue: https://www.illumos.org/issues/3993
    OpenZFS-issue: https://www.illumos.org/issues/4700
    OpenZFS-commit: openzfs/openzfs@c58b352
    
    Porting notes:
    I removed ZoL's zpool_get_prop_literal() in favor of
    zpool_get_prop(..., boolean_t literal) since that's what OpenZFS
    uses.  The functionality is the same.
    xen0l committed with behlendorf May 9, 2016
Commits on May 10, 2016
  1. @behlendorf

    Add zfs-helpers.sh script

    Add a script designed to facilitate in-tree development and testing
    by installing symlinks on your system which refer to in-tree helper
    utilities.  These helper utilities must be installed to in order to
    exercise all ZFS functionality.  By using symbolic links and keeping
    the scripts in-tree during development they can be easily modified
    and those changes tracked.
    
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
    Closes #4607
    behlendorf committed May 6, 2016
  2. @tuxoko @behlendorf

    OpenZFS 6842 - Fix empty xattr dir causing lockup

    Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>
    Ported-by: Denys Rtveliashvili <denys@rtveliashvili.name>
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    
    An initial version of this patch was applied in commit 29572cc and
    subsequently refined upstream.  Since the implementations do not
    conflict with each other both are left applied for now.
    
    OpenZFS-issue: https://www.illumos.org/issues/6842
    OpenZFS-commit: openzfs/openzfs@02525cd
    Closes #4615
    tuxoko committed with behlendorf Mar 25, 2016
Commits on May 9, 2016
  1. @behlendorf

    OpenZFS 6873 - zfs_destroy_snaps_nvl leaks errlist

    Authored by: Chris Williamson <chris.williamson@delphix.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Paul Dagnelie <pcd@delphix.com>
    Ported-by: Denys Rtveliashvili <denys@rtveliashvili.name>
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    
    lzc_destroy_snaps() returns an nvlist in errlist.
    zfs_destroy_snaps_nvl() should nvlist_free() it before returning.
    
    OpenZFS-issue: https://www.illumos.org/issues/6873
    OpenZFS-commit: openzfs/openzfs@ee06391
    Closes #4614
    Chris Williamson committed with behlendorf Apr 19, 2016
  2. @rtvd @behlendorf

    OpenZFS 6879 - Incorrect endianness swap

    Authored by: Dan Kimmel <dan.kimmel@delphix.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Paul Dagnelie <pcd@delphix.com>
    Ported-by: Denys Rtveliashvili <denys@rtveliashvili.name>
    Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
    
    Incorrect endianness swap for drr_spill.drr_length in libzfs_sendrecv.c
    Instead of drr_write.drr_length, we should be assigning the result of
    the byteswap to drr_spill.drr_length.
    
    OpenZFS-issue: https ://www.illumos.org/issues/6879
    OpenZFS-commit: https ://github.com/openzfs/openzfs/commit/74c8720
    Closes #4613
    rtvd committed with behlendorf May 9, 2016
Something went wrong with that request. Please try again.