Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java 8 time serializers #255

Open
jahto opened this issue Jul 18, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@jahto
Copy link

commented Jul 18, 2018

Before replying with "make a pull request", I'm already considering of doing that. The code is currently part of another project, some pieces and tests still missing, and can be seen at
https://github.com/jahto/HSLDataKafkaExample/tree/master/Utils/src/main/java/com/github/jahto/utils/FSTSerializers/java/time
If you think it would be a welcome contribution to FST, I will finish with the missing pieces and tests, fork FST and do the integration.

@RuedigerMoeller

This comment has been minimized.

Copy link
Owner

commented Sep 15, 2018

as for now fst is still java 7 compatible. however this might get dropped soon, so well contributions are always welcome :)

@jahto

This comment has been minimized.

Copy link
Author

commented Sep 15, 2018

If that means you are ok with the code itself, I'll continue. Have to think first how to make it not even try to compile or run under java 7. Maybe check by reflection, we are running under java 8 or higher, and load this module too. Or just wait until you drop java 7 support.

@martinrosstmc

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2018

Given that JDK 11 is out now can we drop 7 support so that we get these included? :)

Also can we get a dependent project where we can put serializers for common third party libraries in without needing to create a dependency on the main library? e.g. Joda Time and Guava classes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.