New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for firefox open web app #15

Merged
merged 2 commits into from Sep 24, 2014

Conversation

Projects
None yet
2 participants
@Mte90
Contributor

Mte90 commented Aug 4, 2014

With this pull request the web interface check if the browser is Firefox based and support the Open Web App standard.
In this case a popup was showed that ask to the user if he want install the app as an hosted webapp.
This system is supported on Firefox Desktop, Firefox for Android and Firefox OS.
In this way the web interface is saved like a native app in Firefox Desktop and Firefox for Android while in Firefox OS is an app.

Homescreen
App

I don't know the web interface, but i think that a system for check (with localstorage or other solution) for not ask at every refresh of the page if the user want install the app is needed.

Missing the icons

@Mte90

This comment has been minimized.

Show comment
Hide comment
@Mte90

Mte90 Sep 23, 2014

Contributor

any news for this?

Contributor

Mte90 commented Sep 23, 2014

any news for this?

@ACXgit

This comment has been minimized.

Show comment
Hide comment
@ACXgit

ACXgit Sep 24, 2014

Member

Hi Daniele, just the time to create the icons and I'll merge this pull request.
Should the icons be called "/images/logoXX.png" or they could also have different names and path?

Member

ACXgit commented Sep 24, 2014

Hi Daniele, just the time to create the icons and I'll merge this pull request.
Should the icons be called "/images/logoXX.png" or they could also have different names and path?

@Mte90

This comment has been minimized.

Show comment
Hide comment
@Mte90

Mte90 Sep 24, 2014

Contributor

the name and the names is not important, is importa only the reference in the manifest.webapp :-)

PS why the pull contain merge conflicts?

Contributor

Mte90 commented Sep 24, 2014

the name and the names is not important, is importa only the reference in the manifest.webapp :-)

PS why the pull contain merge conflicts?

@ACXgit

This comment has been minimized.

Show comment
Hide comment
@ACXgit

ACXgit Sep 24, 2014

Member

I'm trying to figure it out, it should be ready for an automatic merge as there are only simple code and files addons. Any idea?
EDIT: I can only see a chmod change to footer.php file (755 → 644), is it that?

Member

ACXgit commented Sep 24, 2014

I'm trying to figure it out, it should be ready for an automatic merge as there are only simple code and files addons. Any idea?
EDIT: I can only see a chmod change to footer.php file (755 → 644), is it that?

@Mte90

This comment has been minimized.

Show comment
Hide comment
@Mte90

Mte90 Sep 24, 2014

Contributor

i need to update my repo with the last commit :-)

Contributor

Mte90 commented Sep 24, 2014

i need to update my repo with the last commit :-)

ACXgit added a commit that referenced this pull request Sep 24, 2014

Merge pull request #15 from Mte90/master
Support for Firefox Open Web App

@ACXgit ACXgit merged commit 3f74928 into RuneAudio:master Sep 24, 2014

@ACXgit

This comment has been minimized.

Show comment
Hide comment
@ACXgit

ACXgit Sep 24, 2014

Member

Done :) I'm going to add the icons and adjust paths as soon as possible.

Member

ACXgit commented Sep 24, 2014

Done :) I'm going to add the icons and adjust paths as soon as possible.

@ACXgit

This comment has been minimized.

Show comment
Hide comment
@ACXgit

ACXgit Oct 4, 2014

Member

Icons added, finally 61d6c77

Member

ACXgit commented Oct 4, 2014

Icons added, finally 61d6c77

@Mte90

This comment has been minimized.

Show comment
Hide comment
@Mte90

Mte90 Oct 6, 2014

Contributor

perfect, i wait a new rom with this update :-D

Contributor

Mte90 commented Oct 6, 2014

perfect, i wait a new rom with this update :-D

@ACXgit

This comment has been minimized.

Show comment
Hide comment
@ACXgit

ACXgit Oct 6, 2014

Member

Question for you @Mte90 - I'm getting the following message in the Firebug console:

Install failed

:MULTIPLE_APPS_PER_ORIGIN_FORBIDDEN

How can I get rid of that?

Member

ACXgit commented Oct 6, 2014

Question for you @Mte90 - I'm getting the following message in the Firebug console:

Install failed

:MULTIPLE_APPS_PER_ORIGIN_FORBIDDEN

How can I get rid of that?

@Mte90

This comment has been minimized.

Show comment
Hide comment
@Mte90

Mte90 Oct 6, 2014

Contributor
 MULTIPLE_APPS_PER_ORIGIN_FORBIDDEN
    Installable apps have a "single app per origin" security policy; basically, you can't host more than one installable app per origin.

Source: https://developer.mozilla.org/en-US/docs/Web/API/Apps.install

i've see that in the manifest.webapp you have change the url so when you try to install the system detect that you have an another app with the same domain installed (maybe the version of my pull request).

Contributor

Mte90 commented Oct 6, 2014

 MULTIPLE_APPS_PER_ORIGIN_FORBIDDEN
    Installable apps have a "single app per origin" security policy; basically, you can't host more than one installable app per origin.

Source: https://developer.mozilla.org/en-US/docs/Web/API/Apps.install

i've see that in the manifest.webapp you have change the url so when you try to install the system detect that you have an another app with the same domain installed (maybe the version of my pull request).

@ACXgit

This comment has been minimized.

Show comment
Hide comment
@ACXgit

ACXgit Dec 18, 2014

Member

I tell you this here as I don't have your email address yet - I just added you here in the main contributors section:
http://www.runeaudio.com/team/
I took the liberty of choosing that profile picture because it's too funny :D

Member

ACXgit commented Dec 18, 2014

I tell you this here as I don't have your email address yet - I just added you here in the main contributors section:
http://www.runeaudio.com/team/
I took the liberty of choosing that profile picture because it's too funny :D

@Mte90

This comment has been minimized.

Show comment
Hide comment
@Mte90

Mte90 Dec 18, 2014

Contributor

Ahahahah an old avatar meshup with terminator XD

Contributor

Mte90 commented Dec 18, 2014

Ahahahah an old avatar meshup with terminator XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment