-
Notifications
You must be signed in to change notification settings - Fork 6
[Fix] #250 - 파이어베이스 공용계정으로 이전 하였습니다. #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
faac876
db81d6b
e758433
77fc651
ec4e915
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -185,11 +185,13 @@ extension CourseDetailVC { | |
| let description = publicCourse.description | ||
| let courseImage = publicCourse.image | ||
|
|
||
| let dynamicLinksDomainURIPrefix = "https://runnect.page.link" | ||
| let dynamicLinksDomainURIPrefix = "https://rnnt.page.link" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr 작업한 내용에 언급해주신거 확인했습니다 ~ |
||
| guard let link = URL(string: "\(dynamicLinksDomainURIPrefix)/?courseId=\(courseId)") else { | ||
| return | ||
| } | ||
|
|
||
| print("‼️link= \(link)") | ||
|
|
||
| guard let linkBuilder = DynamicLinkComponents(link: link, domainURIPrefix: dynamicLinksDomainURIPrefix) else { | ||
| return | ||
| } | ||
|
|
@@ -198,6 +200,8 @@ extension CourseDetailVC { | |
| linkBuilder.iOSParameters?.appStoreID = "1663884202" | ||
| linkBuilder.iOSParameters?.minimumAppVersion = "1.0.4" | ||
|
|
||
| linkBuilder.androidParameters = DynamicLinkAndroidParameters(packageName: "com.runnect.runnect") | ||
|
|
||
| linkBuilder.socialMetaTagParameters = DynamicLinkSocialMetaTagParameters() | ||
| linkBuilder.socialMetaTagParameters?.imageURL = URL(string: courseImage) | ||
| linkBuilder.socialMetaTagParameters?.title = title | ||
|
|
@@ -210,7 +214,7 @@ extension CourseDetailVC { | |
|
|
||
| /// 짧은 Dynamic Link로 변환하는 부분 입니다. | ||
| linkBuilder.shorten { [weak self] url, _, error in // warning 파라미터 와일드 카드 | ||
| guard let shortDynamicLink = url else { | ||
| guard let shortDynamicLink = url?.absoluteString else { | ||
| if let error = error { | ||
| print("❌Error shortening dynamic link: \(error)") | ||
| } | ||
|
|
@@ -220,7 +224,7 @@ extension CourseDetailVC { | |
| print("🔥The short URL is: \(shortDynamicLink)") | ||
|
|
||
| DispatchQueue.main.async { | ||
| let activityVC = UIActivityViewController(activityItems: [shortDynamicLink.absoluteString], applicationActivities: nil) | ||
| let activityVC = UIActivityViewController(activityItems: [shortDynamicLink], applicationActivities: nil) | ||
| activityVC.popoverPresentationController?.sourceView = self?.view | ||
| self?.present(activityVC, animated: true, completion: nil) | ||
| } | ||
|
|
@@ -318,8 +322,8 @@ extension CourseDetailVC { | |
| model.publicCourse.departure.town, | ||
| model.publicCourse.departure.name | ||
| ] | ||
| .compactMap { $0 } | ||
| .joined(separator: " ") | ||
| .compactMap { $0 } | ||
| .joined(separator: " ") | ||
|
|
||
| self.courseDepartureInfoView.setDescriptionText(description: locate) | ||
| self.courseExplanationTextView.text = model.publicCourse.description | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -211,7 +211,7 @@ extension MarathonMapCollectionViewCell { | |
| LoadingIndicator.hideLoading() | ||
| } | ||
|
|
||
| guard let self = self else { return } | ||
| guard self != nil else { return } | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 코드는 옵셔널 바인딩이 아니라 nil인지 아닌지를 확인하는 코드인건가요 ?! |
||
|
|
||
| switch response { | ||
| case .success(let result): | ||
|
|
||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,13 @@ | ||
| git_url("https://github.com/thingineeer/fastlane-match") | ||
| git_branch("master") | ||
|
|
||
| git_branch("Runnect") # 'Runnect' 앱을 위한 인증서 관리를 할 브랜치 | ||
| storage_mode("git") | ||
|
|
||
| type("appstore") # The default type, can be: appstore, adhoc, enterprise or development | ||
| type("development") # The default type, can be: appstore, adhoc, enterprise or development | ||
|
|
||
| app_identifier(ENV["APP_IDENTIFIER"]) | ||
| # app_identifier(["tools.fastlane.app", "tools.fastlane.app2"]) | ||
| # username("user@fastlane.tools") # Your Apple Developer Portal username | ||
|
|
||
| # For all available options run `fastlane match --help` | ||
| # Remove the # in the beginning of the line to enable the other options | ||
|
|
||
| # The docs are available on https://docs.fastlane.tools/actions/match | ||
| # The docs are available on https://docs.fastlane.tools/actions/match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
카카오 주소 검색 api 나중에 혹~시라도 활용할까봐 남겨뒀는데
사용하지 않을 것 같아서 관련 issue(191번)에서 작업하고 다시 언급드리겠습니당 ~ 이런거 하나까지 꼼꼼하게 봐주셔서 감사합니다 🙇🏻♀️