[Feat] #81 - 코스업로드하기 API 연결 완료 #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lee-yeonwoo
requested review from
dlwogus0128 and
lsj8706
and removed request for
lsj8706
lsj8706
reviewed
Jan 12, 2023
| self.mapImageView.setImage(with: imageUrl) | ||
| } | ||
|
|
||
| private func pushToCourseDiscoveryVC() { |
Collaborator
There was a problem hiding this comment.
CourseDiscoveryVC는 탭바에 기본으로 들어가 있는 VC여서 CourseDiscoveryVC로 가고 싶다면 이렇게 새로 VC를 만들어서 push를 하는게 아니라 Pop을 해서 되돌아가야합니다..! 밑에 코멘트 참고해주세요~!
| do { | ||
| let responseDto = try result.map(BaseResponse<RunningRecordResonseData>.self) | ||
| if responseDto.status == 200 { | ||
| self.pushToCourseDiscoveryVC() |
Collaborator
There was a problem hiding this comment.
Suggested change
| self.pushToCourseDiscoveryVC() | |
| self.navigationController?.popToRootViewController(animated: true) |
이렇게 하면 navigation Stack의 가장 밑에 있는 최초의 VC로 돌아가게 됩니다. 여기서는 CourseDiscoveryVC가 되는 것이죠!
...ct-iOS/Runnect-iOS/Network/Dto/CourseDiscoveryDto/RequestDto/CourseUploadingRequestDto.swift
Outdated
Show resolved
Hide resolved
| object: nil) | ||
| } | ||
|
|
||
| func setData(runningModel: RunningModel) { |
Collaborator
There was a problem hiding this comment.
혹시 기존에 여기에 setData 함수를 제가 만들어 둔게 있는데 그 함수는 삭제하신건가요? 아니면 Pull을 안받아서 없는걸까요...?
여기서는 runningModel 대신에 제가 원래 setData에 넣어둔 Course 객체를 이용해 UI를 잘 뿌려주고 있었습니다..! 딱히 건드릴 필요 없었다는 의미에요~!
#82
여기 PR에 적혀있는 내용 참고해주세요~!
Collaborator
Author
There was a problem hiding this comment.
헛 풀을 안받고 pr날려서 ㅠ
Runnect-iOS/Runnect-iOS/Presentation/CourseDiscovery/Views/VC/CourseUploadVC.swift
Show resolved
Hide resolved
Runnect-iOS/Runnect-iOS/Presentation/CourseDiscovery/Views/VC/CourseUploadVC.swift
Outdated
Show resolved
Hide resolved
Runnect-iOS/Runnect-iOS/Presentation/CourseDiscovery/Views/VC/CourseUploadVC.swift
Outdated
Show resolved
Hide resolved
lsj8706
reviewed
Jan 12, 2023
Runnect-iOS/Runnect-iOS/Network/Model/RunningModel/RunningModel.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
📸 스크린샷
📮 관련 이슈