Skip to content

Conversation

@abmusse
Copy link
Contributor

@abmusse abmusse commented Aug 27, 2018

In response to issue #68

@sjanuary
Copy link
Contributor

@Ab-m you have several TODOs in this PR. Would it make sense to complete these before I merge this and tag a new branch and we put a release out? There's quite a lot of overhead for our team to do an appmetrics release so we don't do it very frequently.

@ThePrez
Copy link

ThePrez commented Sep 12, 2018

@sjanuary, my preference would be to merge the current changes "as is", simply because:

  • the remaining TODO items are non-trivial in nature and may take us some time to make sure we choose the best solution
  • IBM i customers have a need for appmetrics and appmetrics-dash today, but it is broken entirely in its current state

So, I'd rather have a release with a partial implementation so that customers can be using this tool as soon as possible. Then, we'll fill in the remaining functions as we finalize the implementation for them.

@sjanuary
Copy link
Contributor

@ThePrez - ok, I'm happy to merge it on that basis. We have a release planned for sometime in the next month anyway so we can release what you've done at that point. It would be good to put a statement about iPASE support in the README for appmetrics, perhaps that could be added to RuntimeTools/appmetrics#538?

@sjanuary sjanuary merged commit 85cab6a into RuntimeTools:master Sep 12, 2018
@abmusse
Copy link
Contributor Author

abmusse commented Sep 12, 2018

@sjanuary Yes adding a note in the README is a good idea. I will handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants